Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for channels from the new Brave News API. These replace categoryName. #25688

Closed
fallaciousreasoning opened this issue Sep 29, 2022 · 4 comments · Fixed by brave/brave-core#14445

Comments

@fallaciousreasoning
Copy link

For now, this should be behind the BraveNewsV2 flag. It is a requirement to release the new UI.

@stephendonner
Copy link

stephendonner commented Oct 28, 2022

@brave/qa-team hold off on testing this (and other feed/channel-related issues) until after the fixes for issues in https://bravesoftware.slack.com/archives/CU56GUJ1H/p1666975874847419 have been pushed to production.

And brave/brave-core#15749

@stephendonner
Copy link

Removing QA/Blocked; I believe everything needed for testing has landed in the client and/or pushed to prod 👍

@stephendonner
Copy link

Removing QA/Blocked; I believe everything needed for testing has landed in the client and/or pushed to prod 👍

Though it would be good to hold off until brave/brave-core#15808 is merged, I now realize (not technically blocked, but we'd have to re-do testing, since there are channel-related tweaks -- including the ability to be translatable -- in there).

@stephendonner
Copy link

Verification PASSED using

Brave 1.46.100 Chromium: 107.0.5304.91 (Official Build) dev (x86_64)
Revision 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS macOS Version 11.7.1 (Build 20G918)

Steps:

  1. installed 1.46.100
  2. launched Brave
  3. clicked Skip welcome tour
  4. scrolled down on the new-tab page
  5. clicked on Show Brave News
  6. confirmed the usual mix of news, sports, entertainment, health, etc. categories/feeds
  7. loaded brave://flags
  8. enabled the brave://flags/#brave-news-v2 flag
  9. closed Brave
  10. relaunched Brave
  11. with the default Top Sources category followed, scrolled Brave News
  12. confirmed Gamespot articles
  13. unfollowed Top Sources
  14. followed Entertainment, reloaded
  15. scrolled Brave News
  16. confirmed Gamespot articles, reloaded
  17. unfollowed Entertainment
  18. followed Gaming, reloaded
  19. scrolled Brave News

Confirmed the Gamespot feed was present in the Entertainment, Gaming, and Top Sources categories, with articles, without directly following it.

Entertainment

Customize dialog Gamespot in feed
Screen Shot 2022-11-08 at 12 26 03 PM Screen Shot 2022-11-08 at 12 28 12 PM

Gaming

Customize dialog Gamespot in feed
Screen Shot 2022-11-08 at 12 37 43 PM Screen Shot 2022-11-08 at 12 39 19 PM

Top Sources

Customize dialog Gamespot in feed
Screen Shot 2022-11-08 at 12 25 42 PM Screen Shot 2022-11-08 at 12 27 15 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment