Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brave://apps has an ugly gray color as the background #25736

Open
urbenlegend opened this issue Sep 30, 2022 · 13 comments
Open

brave://apps has an ugly gray color as the background #25736

urbenlegend opened this issue Sep 30, 2022 · 13 comments

Comments

@urbenlegend
Copy link

Description

Ever since #16078 was fixed, brave://apps has been displaying an ugly gray color as the background that doesn't suit the application theme at all.

Steps to Reproduce

  1. Navigate to brave://apps
  2. Notice that the background color is an ugly gray.

Actual result:

image

Expected result:

brave://apps background should match the selected Brave theme in settings.

Reproduces how often:

Every time

Brave version (brave://version info)

1.44.101 Chromium: 106.0.5249.65 (Official Build) (64-bit)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Not tested
  • Can you reproduce this issue with the nightly channel? Not tested

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? No

Miscellaneous Information:

@bbondy
Copy link
Member

bbondy commented Oct 3, 2022

Yes but I think the best place to fix this issue is in Chromium upstream. I don't think it is Brave specific.

@urbenlegend
Copy link
Author

@bbondy But I believe this issue happened after #16078 was fixed. The default color of blank tabs was changed to avoid flashing white at people in dark mode. brave://apps was perfectly fine before that.

@bbondy
Copy link
Member

bbondy commented Oct 3, 2022

oh ok, so it sounds like it's brave specific then 👍

@rebron
Copy link
Collaborator

rebron commented Oct 3, 2022

cc: @petemill

@urbenlegend
Copy link
Author

Recently, Brave has been showing a completely black background instead of a gray one:
image

The background should follow the color theme instead of being dark all the time.

@ParagGhatage
Copy link

@urbenlegend
I would like to work on this issue.
Will you assign this to me?

@urbenlegend
Copy link
Author

@ParagGhatage I do not have permissions to do so. I am not a Brave employee btw.

@ParagGhatage
Copy link

@ParagGhatage I do not have permissions to do so. I am not a Brave employee btw.

Thanks for the clarification.

@Omvinchhi
Copy link

is this still open ??

@Rishabh6395
Copy link

Recently, Brave has been showing a completely black background instead of a gray one: image

The background should follow the color theme instead of being dark all the time.

How do we reproduce this issue?

@urbenlegend
Copy link
Author

@Rishabh6395 Simply navigate to brave://apps and you'll see the dark background.

@bsclifton
Copy link
Member

bsclifton commented Sep 5, 2024

@urbenlegend are you seeing black background or gray?

I tried with light colors and dark colors and got black on both

@urbenlegend
Copy link
Author

I get black on both as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants