Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Rewards: Ads Panel #2621

Closed
mandar-brave opened this issue Dec 18, 2018 · 5 comments
Closed

Brave Rewards: Ads Panel #2621

mandar-brave opened this issue Dec 18, 2018 · 5 comments

Comments

@mandar-brave
Copy link

Placeholder issue for;

a) the Desktop Brave REwards: Ads Panel (for supported countries)
b) Payments UI flow

cc @jenn-rhim

@mandar-brave mandar-brave added the priority/P2 A bad problem. We might uplift this to the next planned release. label Dec 18, 2018
@mandar-brave
Copy link
Author

@NejcZdovc FYI

@bbondy bbondy modified the milestones: 0.61.x - Nightly, 1.x Backlog Dec 20, 2018
@mandar-brave
Copy link
Author

mandar-brave commented Jan 11, 2019

UI Elements for Brave Ads V1.0
Brave Rewards: Opt in
There are two paths to OPT in; for first time users and for existing users who have opted in to Brave Rewards.

For existing users who have upgraded to Brave-Core, they will see a notification opt-in below;
If the user says Turn on - it will turn on Ads for the browser immediately and accrue rewards.
If the user closes out the notification - Ads will remain turned off

image-1-ads
For new users that are downloading Brave-Core with 0.59/0.60 as their first Brave version, opting into Brave Rewards will automatically opt them in to Ads, along with Auto-Contribute. These users should never see the “Brave Ads has arrived” notification. Instead, turning on Brave Rewards will turn on Brave Ads. This can happen if the user enables Brave Rewards from the Brave Rewards panel, or if they click on the master on switch (for Brave Rewards as a whole) in Brave Rewards settings.

For users that have the Brave-Core browser but have not opted in to Brave Rewards, no notification is presented when upgraded to 0.59/0.60 build (or later).

Every user can go to Brave Rewards settings and can opt in/out from the Ads Panel. So users who have decided to opt out may be able to get back and turn Ads on later.
Brave Rewards: Ads Panel (Front)

ads-image-2

The front side of the Ads panel has four entries;
Estimated rewards since last payment keeps count of all unaccounted confirmed tokens that are yet to be paid but accruing at the client end. The client can aggregate payouts as confirmations come back to the client, aggregated once per day.
Next payment by date shows the date by which the current months payment will be made available to the user.
The Ad notifications received is the total Ad notifications that showed up on the browser. Updated in near real time based on event logs.
The Ad pages viewed is the total landing pages that the user visited and spent 15 seconds on. Update in near real time based on event logs.

At the end of each month, the estimated earnings, ad notifications, and ad pages counts are reset. When the payment captcha is available, the Next payment-by date is updated to the next month.
Brave Rewards: Ads Panel (Back)

ads-image-3

The user will have the choice to set Ads per Hour on the Brave Core desktop as part of the Ads settings. The range of this is 1-6 with default setting at 2 per hour.

ads-image-4

Brave Rewards: Ads Payments workflow
Here is the aggregated view of Ads Panel and the Wallet view for Brave Ads.
At the end of each month,
Estimated rewards gets reset to 0
Ad notifications received is reset to 0
Ad pages viewed is reset to 0
At the 8th of each month;
The Pay by date will reset to the next month
The server will get payments out on the 8th of each month for Ads and the client will receive a Captcha

ads-image-5

Brave Rewards: Region not supported Ads Panel
For regions outside of launch areas Ads opt in will be completely disabled for 0.59/0.60 releases. The on/off toggle is grayed out to prevent users from opt in.
ads-image-6

@mrose17
Copy link
Member

mrose17 commented Jan 17, 2019

@mandar-brave - i believe that the only thing left here is what is in #2562 ... so i think we can close this now. do you agree?

@mandar-brave
Copy link
Author

Fine @mrose17; we can close this - will file if we see any gaps from a QA perspective.

@mrose17 mrose17 closed this as completed Jan 17, 2019
@srirambv
Copy link
Contributor

@mandar-brave @mrose17 should this be part of 0.59.x or is this a dupe of #2562 ?

@srirambv srirambv modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Jan 29, 2019
@kjozwiak kjozwiak added closed/invalid and removed feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. labels Feb 6, 2019
@rebron rebron removed this from the Dupe / Invalid / Not actionable milestone May 10, 2019
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Jun 3, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants