Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSS Autodiscovery popup bugs #26352

Closed
mattmcalister opened this issue Oct 28, 2022 · 3 comments · Fixed by brave/brave-core#15715
Closed

RSS Autodiscovery popup bugs #26352

mattmcalister opened this issue Oct 28, 2022 · 3 comments · Fixed by brave/brave-core#15715

Comments

@mattmcalister
Copy link

Description

  1. Incorrect icon showing in address bar when visiting a site that is not in the sources list
  2. Empty follow button when not following a feed until you mouseover the button
  3. Sometimes the icon doesn't appear at all

Steps to Reproduce

  1. Visit theregister.com
  2. Click the old RSS autodiscovery icon
  3. Mouseover the follow buttons
  4. Visit infoworld.com or towardsdatascience.com
  5. No RSS autodiscovery icon
  6. View page source to find the RSS feed

Example

image

@stephendonner
Copy link

@fallaciousreasoning @petemill can we please get this uplifted to 1.46.x?

@kjozwiak
Copy link
Member

kjozwiak commented Nov 7, 2022

The above requires 1.46.97 or higher for 1.46.x verification 👍

@stephendonner
Copy link

Verified PASSED using

Brave 1.46.97 Chromium: 107.0.5304.91 (Official Build) beta (x86_64)
Revision 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS macOS Version 13.1 (Build 22C5033e)

Steps:

  1. installed 1.46.97
  2. launched Brave
  3. opened brave://flags
  4. set both Brave News v2 and Brave News Subscribe button to Enabled
  5. clicked on Relaunch
  6. loaded infoworld.com and towardsdatascience.com
  7. for each, clicked on the Manage Subscriptions icon in the URL bar
  8. ensured I could Follow each
  9. opened the Customize News dialog
  10. ensured they were listed
  11. opened the Brave News feed on a new-tab page

infoworld.com

1 2 3 4
Screenshot 2022-11-07 at 9 13 30 PM Screenshot 2022-11-07 at 9 14 00 PM Screenshot 2022-11-07 at 9 14 15 PM Screenshot 2022-11-07 at 9 14 54 PM

towardsdatascience.com

1 2 3 4
Screenshot 2022-11-07 at 9 15 15 PM Screenshot 2022-11-07 at 9 15 20 PM Screenshot 2022-11-07 at 9 15 32 PM Screenshot 2022-11-07 at 9 15 45 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment