Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Brave News] The Brave News V2 page should be updated to match new design specs #26462

Closed
fallaciousreasoning opened this issue Nov 2, 2022 · 2 comments · Fixed by brave/brave-core#15755

Comments

@fallaciousreasoning
Copy link

After some discussion with the designers, we've worked out a more consistent design for the home page:

  1. Popular sources should appear first
  2. Suggestions should appear second
  3. Channels should appear third
  4. All channels should be visible
  5. Popular/Suggestions should appear in a Carousel, with a view all link taking you to a full page view
  6. We should remove the All Sources section
@kjozwiak
Copy link
Member

kjozwiak commented Nov 8, 2022

The above will require 1.46.100 or higher for 1.46.x verification 👍

@stephendonner
Copy link

stephendonner commented Nov 8, 2022

Verification PASSED using

Brave 1.46.100 Chromium: 107.0.5304.91 (Official build) dev (x86_64)
Revision 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS macOS Version 11.7.1 (Build 20G918)

Steps:

  1. launched Brave
  2. clicked on Skip welcome tour
  3. opened brave://flags
  4. set brave://flags/#brave-news-v2 to Enabled
  5. clicked Relaunch
  6. opened a new-tab page
  7. clicked on Customize
  8. clicked on Brave News
  9. clicked on Turn on Brave News
  10. checked the Customize Brave News dialog

Confirmed the following changes:

  • Popular sources appeared first
  • Suggestions appeared second (after following a few sources, then returning to this dialog)
  • Channels appeared third
  • All channels were visible (no Show more button)
  • Popular & Suggestions appeared in a carousel, with a View All link taking me to a full page view
  • removed previous Sources section
order of appearance all channels visible carousel
Screen Shot 2022-11-08 at 9 06 49 AM Screen Shot 2022-11-08 at 9 07 25 AM Screen Shot 2022-11-08 at 9 08 24 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment