Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback button when ipfs page can't be loaded #26486

Closed
cypt4 opened this issue Nov 2, 2022 · 1 comment · Fixed by brave/brave-core#20403
Closed

Add fallback button when ipfs page can't be loaded #26486

cypt4 opened this issue Nov 2, 2022 · 1 comment · Fixed by brave/brave-core#20403
Assignees

Comments

@cypt4
Copy link

cypt4 commented Nov 2, 2022

image
We have a feature which auto-redirects to ipfs:// resources when dnslink or gateway-like url is loaded.
We should give an opportunity to the user to load original url in case ipfs url can't be loaded.

There are several cases we should handle:

  1. Cannot resolve remote gateway or cannot start local node, so chromium error page is shown
  2. Remote gateway is resolved but resource is not loaded since it is not available. Like https://ipfs.io/ipfs/123
  3. Local gateway is started but we block request because CID or IPNS is invalid : ipfs://123 or ipns://abc.com
  4. Local gateway is started but it cannot resolve CID or IPNS since it has network problems or resource is unavailable.

Probably the easiest way would be to show fallback Infobar witch suggest to load original url neither to show error page in all cases.

Redirect logic is mostly covered in ipfs_tab_helper

Follow up: Same functionality but when redirect is fired by addressbar button or ipfs promo infobar

@srirambv
Copy link
Contributor

srirambv commented Dec 6, 2023

Verification passed on

Brave 1.62.97 Chromium: 120.0.6099.56 (Official Build) beta (64-bit)
Revision 9561bb49dc23c407275af722586f045356609329
OS Linux
  • Verified steps from brave/brave-core#20403
  • Verified with network blocked and Automatically redirect requests for IPFS network resources to the configured gateway. set to on and Method to resolve IPFS resource set to Brave local IPFS node, a new info bar is shown with Redirect and No thanks
  • Verified clicking on Redirect button on the infobar redirects to the public gateway link
  • Verified clicking on No thanks button on the infobar tries to load via localhost
26486.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants