Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad layout on https://www.forbes.com #27086

Closed
boocmp opened this issue Dec 1, 2022 · 1 comment · Fixed by brave/brave-core#16186
Closed

Bad layout on https://www.forbes.com #27086

boocmp opened this issue Dec 1, 2022 · 1 comment · Fixed by brave/brave-core#16186

Comments

@boocmp
Copy link

boocmp commented Dec 1, 2022

Description

Article looks ugly in speedreader.

We decided to remove all svg images from the distilled page because we assume that svgs used to display any icons (e.g. on buttons) and these icons are most likely not meaningful content.

Steps to Reproduce

  1. Enable speedreader
  2. Navigate to https://www.forbes.com/sites/thomasbrewster/2019/08/15/apple-is-suing-a-cybersecurity-startup-for-illegally-replicating-iphones/

Actual result:

Page looks ugly because of very big icons

Expected result:

Page looks readable

Reproduces how often:

Easy/100%

@stephendonner
Copy link

Verified PASSED using

Brave 1.48.121 Chromium: 109.0.5414.87 (Official Build) beta (x86_64)
Revision 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS macOS Version 11.7.2 (Build 20G1020)

Steps:

  1. installed 1.48.121
  2. launched Brave
  3. loaded https://www.forbes.com/sites/thomasbrewster/2019/08/15/apple-is-suing-a-cybersecurity-startup-for-illegally-replicating-iphones/
  4. enabled Speedreader mode
  5. viewed the page

Confirmed no more giant icons appearing in the Speedreader-mode's content

1.48.121 1.48.121 1.47.169 1.47.169
Screen Shot 2023-01-11 at 4 54 34 PM Screen Shot 2023-01-11 at 4 54 39 PM Screen Shot 2023-01-11 at 4 48 55 PM Screen Shot 2023-01-11 at 4 49 05 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment