Not receiving Brave VPN credentials with recent nightly

[stephendonner]

Description

Not receiving Brave VPN credentials with recent nightly

NOTE: this is not brave-intl/challenge-bypass-server#315, although they have the same symptoms and appear that way - this only affects nightly clients, while the other affected all release and beta clients, in addition. Different root causes.

Steps to Reproduce

Pre-requisite: remove any BraveVPN config from previous testing

1. installed 1.48.53
2. launched Brave
3. set brave://flags/#brave-vpn to Enabled
4. clicked Relaunch
5. loaded account.bravesoftware.com
6. entered basic-auth credentials
7. entered [email protected] into the textfield
8. clicked on Get login link
9. clicked on the Log in to Brave button in the resulting email
10. clicked on Browse plans
11. scrolled down to Brave VPN Subscription
12. clicked on Buy now
13. completed Stripe purchase details
14. clicked Subscribe
15. waited
16. clicked on VPN button in the browser toolbar, and got the VPN ad card
17. clicked on Refresh Brave VPN button
18. examined error state

Actual result:

No valid credentials were issued/received.

1	2	3	4

Expected result:

Valid credentials

I think this broke in 1.48.47, and works in 1.48.44 - @simonhong think it might be some of your changes?

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.48.53 Chromium: 108.0.5359.99 (Official Build) nightly (64-bit)
Revision	410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS	Windows 10 Version 22H2 (Build 19045.2364)

Version/Channel Information:

• Can you reproduce this issue with the current release? No
• Can you reproduce this issue with the beta channel? No
• Can you reproduce this issue with the nightly channel? Yes

Miscellaneous Information:

/cc @mattmcalister @rebron @husobee @evq @brave/qa-team @simonhong @spylogsster

[stephendonner]

Verified PASSED using

Brave	1.48.54 Chromium: 108.0.5359.128 (Official Build) nightly (64-bit)
Revision	1cd27afdb8e5d057070c0961e04c490d2aca1aa0-refs/branch-heads/5359@{#1185}
OS	Windows 10 Version 22H2 (Build 19045.2364)

Steps

Followed my original steps to reproduce

Confirmed I was able to purchase, configure, and connect to BraveVPN

[stephendonner]

Verified PASSED using

Brave	1.48.125 Chromium: 109.0.5414.87 (Official Build) beta (x86_64)
Revision	2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS	macOS Version 11.7.2 (Build 20G1020)

Steps:

1. installed 1.48.125
2. launched Brave
3. set brave://flags/#brave-vpn to Enabled
4. clicked Relaunch
5. loaded account.bravesoftware.com
6. entered basic-auth credentials
7. entered [email protected] into the textfield
8. clicked on Get login link
9. clicked on the Log in to Brave button in the resulting email
10. clicked on Browse plans
11. scrolled down to Brave VPN Subscription
12. clicked on Buy now
13. completed Stripe purchase details
14. clicked Subscribe
15. waited
16. clicked on the VPN button in the browser toolbar
17. clicked Allow to add the BraveVPN config to macOS
18. clicked again on the VPN button

Confirmed I was issued and used valid credentials for BraveVPN

example	example	example