Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Learn more links under Help improve Brave via brave://welcome are opening brave://settings/privacy tabs #27401

Closed
kjozwiak opened this issue Dec 15, 2022 · 2 comments · Fixed by brave/brave-core#17360
Assignees
Labels
bug onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/exclude

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Dec 15, 2022

Description

When clicking on the Learn more links via the Help improve Brave under brave://welcome, you'll notice that it also opens brave://settings/privacy tabs. It should only be opening the links that are mentioned via #27339 (comment).

Test plan / Steps to Reproduce

  1. launch 1.48.58 Chromium 108.0.5359.128
  2. skip through all of the onboarding screens via brave://welcome till you get to the Help improve Brave screen
  3. click on Learn more and notice that brave://settings/privacy tabs are being opened

Also see steps in brave/brave-core#17360

Actual result:

Welcome.to.Brave.-.Brave.2022-12-15.11-18-30.mp4

Expected result:

We shouldn't be opening brave://settings/privacy tabs as per #27339 (comment).

Reproduces how often:

100% reproducible when using the STR/Cases outlined above.

Brave version (brave://version info)

Brave | 1.48.58 Chromium: 108.0.5359.128 (Official Build) nightly (64-bit)
-- | --
Revision | 1cd27afdb8e5d057070c0961e04c490d2aca1aa0-refs/branch-heads/5359@{#1185}
OS | Windows 11 Version 22H2 (Build 22621.963)

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@kjozwiak kjozwiak added bug QA/Yes release-notes/exclude onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop labels Dec 15, 2022
@rebron rebron assigned rebron and nullhook and unassigned nullhook and rebron Jan 18, 2023
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jan 18, 2023
@rebron
Copy link
Collaborator

rebron commented Feb 24, 2023

cc: @spylogsster

@stephendonner
Copy link

Verified PASSED using

Brave 1.50.86 Chromium: 111.0.5563.64 (Official Build) beta (x86_64)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS macOS Version 11.7.4 (Build 20G1120)

Confirmed clicking on each link opened it in a new tab, without also opening brave://settings/privacy

1st Learn more 2nd Learn more
Screen Shot 2023-03-12 at 10 02 04 PM Screen Shot 2023-03-12 at 10 02 10 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants