Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent mouse cursor handling on buttons for onboardingv2 #27435

Open
btlechowski opened this issue Dec 19, 2022 · 1 comment
Open

Inconsistent mouse cursor handling on buttons for onboardingv2 #27435

btlechowski opened this issue Dec 19, 2022 · 1 comment
Labels
onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop QA/Yes release-notes/exclude

Comments

@btlechowski
Copy link

Generally mouse cursor changes when hovering over a button.
In some instances this is not the case

Steps to Reproduce

Test case 1:

  1. Enter onboardingv2
  2. Click Skip
  3. Hover over one of the browsers from Import Settings

Test case 2:

  1. Enter onboardingv2
  2. Click Skip
  3. Click one of the browsers from Import Settings
  4. Click Import
  5. Hover over Back button in the top left corner

Test case 3:

  1. Enter onboardingv2
  2. Click Skip
  3. Click one of the browsers from Import Settings
  4. Click Import
  5. Hover over one of the profiles

Actual result:

Mouse cursor is not changed on hover
Test case 1:
image

Test case 2:
image

Test case 3:
image

Expected result:

Mouse cursor is changed on hover
Example:
image

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.47.132 Chromium: 108.0.5359.128 (Official Build) beta (64-bit)
Revision 1cd27afdb8e5d057070c0961e04c490d2aca1aa0-refs/branch-heads/5359@{#1185}
OS Ubuntu 18.04 LTS

cc @rebron @nullhook @kjozwiak

@btlechowski btlechowski added QA/Yes release-notes/exclude onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop labels Dec 19, 2022
@kjozwiak
Copy link
Member

kjozwiak commented Jan 9, 2023

hi, I think I can solve this problem can you guide me how will I do it as it going to be my first contribution

I would start by cloning or repo and setting up a development environment following the instructions from https://github.com/brave/brave-browser/#readme (this is assuming you haven't done that yet). Once that's done, I'm sure someone from the engineering team can help point you in the right direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop QA/Yes release-notes/exclude
Projects
Status: On Deck
Development

No branches or pull requests

2 participants