Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Backup" tab in Manage section in brave://rewards #27547

Closed
4 tasks done
Miyayes opened this issue Dec 26, 2022 · 3 comments · Fixed by brave/brave-core#17173
Closed
4 tasks done

Remove "Backup" tab in Manage section in brave://rewards #27547

Miyayes opened this issue Dec 26, 2022 · 3 comments · Fixed by brave/brave-core#17173
Assignees
Labels
feature/rewards OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/include

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Dec 26, 2022

Description

  • Remove "Backup" tab in the brave://rewards manage section
  • Rename to "Reset Brave Rewards"
  • Change brave://rewards "Manage" button to say "Reset"
  • Remove the pill tab selector in the modal
@Miyayes Miyayes added feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop labels Dec 26, 2022
@Miyayes Miyayes added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jan 4, 2023
@Miyayes Miyayes added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Feb 2, 2023
@brave-builds brave-builds added this to the 1.50.x - Nightly milestone Feb 14, 2023
@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 13, 2023
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 13, 2023

Verification PASSED on

Brave | 1.50.85 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
-- | --
Revision | c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS | Windows 10 Version 21H2 (Build 19044.2604)

Example Example Example Example
image image image image

@GeetaSarvadnya GeetaSarvadnya added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 13, 2023
@GeetaSarvadnya
Copy link

@Miyayes Looks like this issue is applicable for Desktop only as we don't see "Backup" tab in brave://rewards, correct me if I am missing anything
cc: @deeppandya @LaurenWags

@Miyayes Miyayes removed the OS/Android Fixes related to Android browser functionality label Mar 14, 2023
@Miyayes
Copy link
Collaborator Author

Miyayes commented Mar 14, 2023

@GeetaSarvadnya Yes that's correct. Deep and Emerick were working on also using the "Manage / Reset" modal for Android, but the change wasn't made before this issue, so it is not applicable in this case. I've removed OS/Android for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants