Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll for Brave News is NOT shown in NTP for users in unavailable list countries #27630

Closed
GeetaSarvadnya opened this issue Jan 4, 2023 · 1 comment

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jan 4, 2023

Description

Scroll for Brave News is NOT shown in NTP for users in unavailable list countries

Steps to Reproduce

  1. Follow the steps 1 to 10 from Test case 1 in https://docs.google.com/document/d/1zlWGAhk0X5nFM5vwwZ21LpDfgPX-6m0-oGcCilsGtXk/edit#
  2. Scroll for Brave News is NOT shown in NTP for users in unavailable list countries

Note: User can enable Brave news via Customize in NTP

Actual result:

Scroll for Brave News is NOT shown in NTP for users in unavailable list countries

Expected result:

Scroll for Brave News should be shown in NTP for users in unavailable list countries

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.47.161 Chromium: 109.0.5414.61 (Official Build) beta (64-bit)
Revision 846c6eff1c374cde417a9cdc44193545cc07f354-refs/branch-heads/5414@{#1030}
OS Windows 10 Version 21H2 (Build 19044.1826)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc : @brave/qa-team @mkarolin @Miyayes

@rebron
Copy link
Collaborator

rebron commented Jan 4, 2023

The expected behavior is that the Brave News opt-in card and/or the Scroll for Brave News button on the NTP only shows by default for supported regions/languages:
device system lang=English

  • Japan
  • Mexico
  • Spain
  • Brazil

Else, the opt-in card and/or Scroll for Brave News does NOT appear by default.
also, all users, regardless of lang/region, can turn on Brave News from the Customize modal on NTP. if Brave News has been enabled then the Scroll for Brave News button should always appear on NTP.

We can mark this as invalid.

@rebron rebron closed this as completed Jan 4, 2023
@Miyayes Miyayes changed the title Scroll for Brave News is NOT shown in NTP for users in OFAC list countries Scroll for Brave News is NOT shown in NTP for users in unavailable list countries Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants