Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brave://welcome import is missing Yandex #27760

Closed
stephendonner opened this issue Jan 11, 2023 · 3 comments · Fixed by brave/brave-core#16667
Closed

brave://welcome import is missing Yandex #27760

stephendonner opened this issue Jan 11, 2023 · 3 comments · Fixed by brave/brave-core#16667
Assignees
Labels
bug feature/importer onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude

Comments

@stephendonner
Copy link

Description

brave://welcome import is missing Yandex

This is a followup issue found while testing #27301.

Steps to Reproduce

  1. populate a Yandex browser with at least bookmarks
  2. install 1.48.121
  3. launch Brave
  4. on brave://welcome look for Yandex as an import options

Actual result:

Yandex is missing

Screen Shot 2023-01-11 at 11 25 48 AM

Expected result:

Yandex should be available to import from, with both an icon and its name present on brave://welcome

Note: it correctly shows up in brave://settings/importData 👍

Screen Shot 2023-01-11 at 11 25 33 AM

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.48.121 Chromium: 109.0.5414.87 (Official Build) beta (x86_64)
Revision 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS macOS Version 11.7.2 (Build 20G1020)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

/cc @rebron @spylogsster @MadhaviSeelam @nullhook @brave/qa-team

@stephendonner stephendonner added bug QA/Yes onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop labels Jan 11, 2023
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. feature/importer labels Jan 12, 2023
@brave-builds brave-builds added this to the 1.49.x - Nightly milestone Jan 13, 2023
@MadhaviSeelam MadhaviSeelam added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA/Test-All-Platforms labels Feb 6, 2023
@MadhaviSeelam
Copy link

MadhaviSeelam commented Feb 7, 2023

Verification PASSED using

Brave | 1.49.88 Chromium: 110.0.5481.77 (Official Build) beta (64-bit)
-- | --
Revision | 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS | Windows 11 Version 21H2 (Build 22000.1455)

and

Brave | 1.49.89 Chromium: 110.0.5481.77 (Official Build) beta (64-bit)
-- | --
Revision | 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS | Windows 11 Version 21H2 (Build 22000.1455)

Filed: #28384
Pre-requisite: Download Yandex browser and have data for History, Bookmarks and Extensions

Profile 1: User 1: Bookmarks, history & extensions

bookmarks history extensions
image image image

Profile 2: Cloud: Bookmarks & History

bookmarks history
image image

Profile 3: Nature Bookmarks
image

Case 1: Verify Yandex icon is available in brave://welcome page - PASSED

  1. Install 1.49.88
  2. launch Brave
  3. click Set Brave as default browser

Confirmed Yandex icon is available in the brave://welcome - first screen

step 3 result
image image

Case 2: Single profile - Complete Import from brave://welcome - Import Settings page - PASSED

  1. continue from Case 1
    • Yandex is shown in brave://welcome page - import settings screen
  2. click Import button
  3. select Yandex User 1 in the Select profile to import screen
  4. clicked Import profiles
  5. verified Setup complete screen is displayed as expected
  6. verified Help improve Brave screen is displayed as expected
  7. verified new-tab page is shown as expected

Confirmed Bookmarks imported from Yandex are shown in brave://bookmarks and bookmarks bar

Confirmed History imported from Yandex is shown in brave://history

Confirmed Extensions imported from Yandex are shown in brave://extensions

step 1-2 step 3-4 step 5 step 6 step 7 result result
image image image image image image image

Case 3: Multiple profiles - Complete Import from brave://welcome - Import Settings page - PASSED

  1. new profile
  2. launch Brave
  3. click Set Brave as default browser on brave://welcome page
  4. select Yandex in import settings screen
  5. click Import button
  6. click Select All to select all 3 profiles
  7. click Import profiles
  8. click Finish
  9. click on Profile icon in the new-tab page next to hamburger menu
    • Confirmed three newly created profiles are shown in the profile manager
    • Confirmed data correctly imported into Yandex User 1, Yandex Nature & Yandex Cloud profiles
    • Confirmed bookmarks, history, and extensions are imported into Yandex User 1 profile
    • Confirmed bookmarks and history are shown in Yandex Cloud profile
    • Confirmed bookmarks are shown in Yandex Nature profile
example example example profile manager User 1 Cloud Nature
image image image image image image image

Note: Brave crashed in 1.49.88 - Filed #28328. But no crash happened in 1.49.89.

Case 4: Bookmarks imported from Yandex should Sync between devices - PASSED

device 1

  1. new profile
  2. launch Brave
  3. click Set Brave as default browser on brave://welcome page
  4. select Yandex and click `Import
  5. select Yandex User 1 and click Import profiles
  6. click Finish
  7. confirmed successful import of Browsing history, Favorites/Bookmarks, Extensions
  8. visit brave://sync
  9. click on Start using sync ---> Start a new Sync Chain
  10. click Computer
  11. copy the code words
  12. under Sync Settings, click on the Sync everything radio button
Step 4 Step 5 Step6 Step 12
image image image image

device 2

  1. go to device 2
  2. click on the "hamburger" menu, and then Sync
  3. click I have a Sync Code
  4. enter/paste the code words from device 1
  5. click Confirm
  6. click OK
  7. under Sync Settings, click on the Sync everything toggle

Confirmed Favorites/Bookmarks, Extensions synced successfully

Note:Browsing history not synced. Only URLs of the sites that were visited in the session are synced

Step 4 Step 7 bookmarks & extensions
image image

@MadhaviSeelam MadhaviSeelam added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Feb 8, 2023
@stephendonner
Copy link
Author

stephendonner commented Feb 13, 2023

Verification PASSED using

Brave 1.49.96 Chromium: 110.0.5481.77 (Official Build) beta (x86_64)
Revision 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS macOS Version 11.7.3 (Build 20G1116)

Case 1: Verify Yandex icon is available in brave://welcome page - PASSED

  1. installed 1.49.96
  2. launched Brave
  3. clicked Set Brave as default browser

Confirmed Yandex icon is available in the brave://welcome Import Settings screen

Screen Shot 2023-02-13 at 10 30 25 AM

Case 2: Single profile - complete import from brave://welcome - import settings page - PASSED

  1. continued from Case 1
  2. clicked Import button
  3. selected Yandex User 1 in the Select profile to import screen
  4. clicked Import profiles
  5. verified Setup complete screen is displayed
  6. verified Help improve Brave screen is displayed as expected
  7. verified new-tab page is shown as expected
example example example example example example example
Screen Shot 2023-02-13 at 10 46 48 AM Screen Shot 2023-02-13 at 10 39 56 AM Screen Shot 2023-02-13 at 10 40 02 AM Screen Shot 2023-02-13 at 10 40 08 AM Screen Shot 2023-02-13 at 10 45 02 AM Screen Shot 2023-02-13 at 10 45 10 AM Screen Shot 2023-02-13 at 10 45 19 AM

Confirmed Bookmarks imported from Yandex are shown in brave://bookmarks and bookmarks bar

Confirmed History imported from Yandex is shown in brave://history

Confirmed Extensions imported from Yandex are shown in brave://extensions

Case 3: Multiple profiles - complete import from brave://welcome - import settings page - PASSED

  1. new profile
  2. launched Brave
  3. clicked Set Brave as default browser on brave://welcome page
  4. selected Yandex in Import Settings screen
  5. clicked Import button
  6. clicked Select All to select the 3 profiles
  7. clicked Import profiles
  8. clicked Finish
example example example profile manager User 1 Doggie Wild Strawberry
Screen Shot 2023-02-13 at 12 30 55 PM Screen Shot 2023-02-13 at 12 31 08 PM Screen Shot 2023-02-13 at 12 31 17 PM Screen Shot 2023-02-13 at 12 19 36 PM Screen Shot 2023-02-13 at 12 24 28 PM Screen Shot 2023-02-13 at 12 24 28 PM Screen Shot 2023-02-13 at 12 26 21 PM

Case 4: Bookmarks imported from Yandex should Sync between devices - PASSED

  1. new profile
  2. launched Brave
  3. clicked Set Brave as default browser on the brave://welcome page
  4. selected Yandex and clicked Import
  5. selected Yandex User 1 and clicked Import profiles
  6. clicked Finish
  7. confirmed successful import of Browsing history, Favorites/Bookmarks, Extensions
  8. opened brave://sync
  9. clicked on Start using sync -> Start a new Sync Chain
  10. clicked Computer
  11. copied the code words
  12. under Sync Settings, clicked on the Sync everything radio button
step 4 step 5 step 6 step 12
Screen Shot 2023-02-13 at 11 14 13 AM Screen Shot 2023-02-13 at 11 14 27 AM Screen Shot 2023-02-13 at 11 14 35 AM Screen Shot 2023-02-13 at 11 17 14 AM

device 2

  1. went to device 2
  2. clicked on the "hamburger" menu, and then Sync
  3. clicked I have a Sync Code
  4. entered the code words from device 1
  5. clicked Confirm
  6. clicked OK
  7. under Sync Settings, clicked on the Sync everything toggle

Note: past browsing history not synced. Only URLs of the sites which were visited in the session are synced

step 4 step 7 bookmarks extensions
Screenshot 2023-02-13 at 11 22 32 AM Screen Shot 2023-02-13 at 11 37 31 AM Screenshot 2023-02-13 at 11 26 02 AM Screenshot 2023-02-13 at 11 26 09 AM

@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Feb 13, 2023
@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 2, 2023
@MadhaviSeelam
Copy link

MadhaviSeelam commented Mar 3, 2023

Verification PASSED using

Brave | 1.49.118 Chromium: 111.0.5563.50 (Official Build) (64-bit)
-- | --
Revision | 39f3dfc5023fe60997adc4f6cf5439cfa3e6968a-refs/branch-heads/5563@{#903}
OS | Linux

Pre-requisite: Download Yandex browser, create 3 profiles and have data for History, Bookmarks and Extensions

User 1 - Apple | User 2 - Wild Strawberry | User 3 -Car ------ | --------- | ------- image|image|image

Case 1: Verify Yandex icon is available in brave://welcome page - PASSED

  1. Install 1.49.118
  2. launch Brave
  3. click Set Brave as default browser

Confirmed Yandex icon is available in the brave://welcome - first screen - PASSED

step 3 result
image image

Case 2: Single profile - complete import from brave://welcome - import settings page - PASSED

  1. Install 1.49.118
  2. launch Brave
  3. click `Set Brave as default browser
  4. select Yandex
  5. click import
  6. select User 1 - Apple
  7. click Import Profiles
  8. click Finish

Confirmed Bookmarks imported from Yandex are shown in brave://bookmarks and bookmarks bar
Confirmed History imported from Yandex is shown in brave://history
Confirmed Extensions imported from Yandex are shown in brave://extensions

step 3 step 4 step 6 step 8 new-tab bookmarks history extensions
image image image image image image image image

Case 3: Multiple profiles - Complete Import from brave://welcome - Import Settings page - PASSED

  1. new profile
  2. launch Brave
  3. click `Set Brave as default browser
  4. select Yandex
  5. click import
  6. select `User 1 - Apple' ,'User 2 - Wild Strawberry', 'User 3 -Car'
  7. click Import Profiles
  8. click Finish
  9. click on Profile icon in the new-tab page next to hamburger menu

Confirmed three newly created profiles with randomly assigned Avatars are shown in the profile manager

Confirmed three newly created profiles have same names from Yandex imports are shown in the profile manager

Confirmed data correctly imported into separate profiles `Yandex User 1 - Apple' ,'Yandex User 2 - Wild Strawberry', 'Yandex User 3 -Car'

Confirmed bookmarks, history, extensions and passwords are imported into Yandex User 1 - Apple

Confirmed bookmarks, history passwords and extensions are shown in Yandex User 2

Confirmed bookmarks, history are shown in Yandex User 3 -Car'

Confirmed Brave Profile 1 is created and shown as expected

step 3 step 4 step 6 step 8 Profile manager new-tab bookmarks history extensions
image image image image image image image image image

Case 4: Bookmarks imported from Yandex should Sync between devices

device 1

  1. continue from Case 3
    • imported multiple profiles from Yandex
    • confirmed successful import of Browsing history, Favorites/Bookmarks, Extensions from all 3 profiles
  2. select Yandex User 1 - Apple from Profile manager
  3. visit brave://sync
  4. click on Start using sync ---> Start a new Sync Chain
  5. click Computer
  6. copy the code words
  7. under Sync Settings, click on the Sync everything radio button
image

device 2

  1. select Profile 1
  2. click on the "hamburger" menu, and then Sync
  3. click I have a Sync Code
  4. enter/paste the code words from device 1
  5. click Confirm
  6. click OK
  7. under Sync Settings, click on the Sync everything toggle

Confirmed Favorites/Bookmarks, Extensions synced successfully

Note:Browsing history not synced. Only URLs of the sites that were visited in the session are synced

Step 1 Step 4 Step 6 Step 7 bookmarks & extensions
image image image image image

@MadhaviSeelam MadhaviSeelam added QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/importer onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants