Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notification modal description and textual button color in dark mode - follow up to #27004 #27767

Closed
kjozwiak opened this issue Jan 12, 2023 · 3 comments · Fixed by brave/brave-core#16658
Assignees
Labels
front-end-change This task is a front end task and doesn't need any C++ changes OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/include

Comments

@kjozwiak
Copy link
Member

Description

Looking at https://github.com/brave/brave-core/pull/16128/files, it doesn't look like any changes were added into the PR that fixes the colour issue(s) discussed via #27004 (comment). When launching Brave for the first time on Android 13, the modal looks the same as before. We need to make sure it we're using the correct colours.

Steps to reproduce

Prerequisite: ensure that you're using dark mode via Android 13 before launching Brave.

Test Case #1

  1. install 1.49.20 Chromium: 109.0.5414.87 using Android 13
  2. run through the initial on-boarding and notice that the notification panel looks the same as before and is hard to read

Test Case #2

  1. install 1.49.20 Chromium: 109.0.5414.87 using Android 13
  2. run through the initial on-boarding and enable notifications
  3. go into Settings -> Notifications and disable all notifications from the Notifications page
  4. tap on <- (back button) and go back to the Settings page (notice the general warning is also using the incorrect colours)

Actual result

Example Example
Screenshot_20230112-002035 Screenshot_20230112-002110

Expected result

Should be using the scheme mentioned via #27004 (comment) and look like https://www.figma.com/file/sdVBBufbl2A11hAgPNfyqG/Android-13-Notifications?node-id=1243%3A31639&t=7Pd5NQyY0I0HjTn0-1. @sujitacharya2005 also added a screenshot of how it was supposed to look via brave/brave-core#16128 (comment).

Issue reproduces how often

100% reproducible using the STR/Cases outlined above.

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Pixel 6 (Phone)
  • Android version: Android 13

Brave version

Brave | 1.49.22 Chromium: 109.0.5414.87 (Official Build) canary (32-bit)
--- | ---
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | Android 13; Build/T2B1.221118.006

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional information

CCing @deeppandya @timchilds @sujitacharya2005

@deeppandya
Copy link

@sujitacharya2005 we need to uplift the change to 1.47

@kjozwiak
Copy link
Member Author

The above requires 1.47.176 or higher for 1.47.x verification 👍

@Uni-verse
Copy link
Contributor

Uni-verse commented Jan 23, 2023

Verified on Samsung Galaxy S21 using version:

Brave	1.47.181 Chromium: 109.0.5414.87 (Official Build) (64-bit) 
Revision	2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS	Android 13; Build/TP1A.220624.014

Prerequisite: ensure that you're using dark mode via Android 13 before launching Brave.

Test Case #1

  1. Install 1.47.181 using Android 13
  2. run through the initial on-boarding and notice that the notification panel looks the same as before and is hard to read

Test Case #2

  1. Install 1.48.171 using Android 13
  2. run through the initial on-boarding and enable notifications
  3. go into Settings -> Notifications and disable all notifications from the Notifications page
  4. tap on <- (back button) and go back to the Settings page (notice the general warning is also using the incorrect colours)
Example Example
screenshot-1674498609664 screenshot-1674498648074

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end-change This task is a front end task and doesn't need any C++ changes OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants