Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move wallet services out of BraveActivity #27887

Open
SergeyZhukovsky opened this issue Jan 18, 2023 · 0 comments
Open

Move wallet services out of BraveActivity #27887

SergeyZhukovsky opened this issue Jan 18, 2023 · 0 comments
Labels
enhancement feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA/No release-notes/exclude

Comments

@SergeyZhukovsky
Copy link
Member

As has been found in that issue #27805 BraveActivity is not a reliable place to store wallet's services connections, it can be killed or closed at any time. We should move them out somewhere that is always alive. Application level perhaps would work perfectly there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA/No release-notes/exclude
Projects
Status: Backlog
Development

No branches or pull requests

1 participant