Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Able to install C110 on both Windows 7 & Win 8.1 #28045

Closed
btlechowski opened this issue Jan 25, 2023 · 11 comments
Closed

Able to install C110 on both Windows 7 & Win 8.1 #28045

btlechowski opened this issue Jan 25, 2023 · 11 comments

Comments

@btlechowski
Copy link

Brave, just like Chrome ends support for Windows 7 and Windows 8

Steps to Reproduce

  1. Install C110 using standalone build

Actual result:

Able to install the build without issue
Running Brave fails:
image

Expected result:

unable to install Brave. Show message that Windows 10 and higher is needed

Reproduces how often:

Easily

Brave version (brave://version info)

BraveBrowserNightlySetup_110_1_49_59.exe on Windows 7 x64

cc @kjozwiak @LaurenWags @rebron @mihaiplesa @wknapik

@btlechowski
Copy link
Author

btlechowski commented Jan 25, 2023

Chrome says in the installer: No available updates. User is not able to update.
But I used stub installer.

image

@kjozwiak kjozwiak changed the title Able to install C110 on Windows 7 Able to install C110 on both Windows 7 & Win 8.1 Jan 26, 2023
@kjozwiak
Copy link
Member

Basically got the same results as @btlechowski on Win 8.1. The only difference is that I didn't received any errors/messages about missing dll files. On Win 8.1, Brave opens and then closes right away (please see attached video example). As @btlechowski pointed out, looks like Chrome presents a warning via the stub install whenever attempting to install C110 or higher. Chrome only offers stub installs so that should be easy to deny installations on Win 7 & Win 8.1. However, we need to figure out a way to block installations of Brave using executables on the affected platforms.

Example video of the crash occurring

crashingWin.mov

Example screenshots of Brave being installed using the executable

Example Example
Screenshot 2023-01-26 at 3 18 37 AM Screenshot 2023-01-26 at 3 19 01 AM

Example screenshots of Chrome being installed using the stub installer

Example Example Example
Screenshot 2023-01-26 at 3 21 06 AM Screenshot 2023-01-26 at 3 23 29 AM Screenshot 2023-01-26 at 3 27 29 AM

@mihaiplesa
Copy link
Contributor

Any ideas here @mherrmann?

@mherrmann
Copy link

mherrmann commented Jan 26, 2023

We're still on CR109 with Nightly. Once we're on 110, our stub installer (i.e. the 1MB online installer) will give the same message as Chrome's: "No update is available".

Regarding the other installers: I expect the behavior reported by @btlechowski and @kjozwiak to continue until we provide a fix. That is, our offline installers will continue to work* in the sense that they will install Brave. But Brave will not launch.

*: Until we change our installer. This can happen when we upgrade from Omaha 3 to 4.

Regarding ideas: I wonder what Chrome will do. Their official offline installer is still on CR 109. My hope is that they will implement a solution we can reuse. I'd be surprised if they just let Chrome crash the way CR 110 seems to be doing now.

@mherrmann
Copy link

(Actually I think our stub installer will install the latest CR109 version until we - at some point in the future - remove it from the update server.)

@kjozwiak
Copy link
Member

We're still on CR109 with Nightly. Once we're on 110, our stub installer (i.e. the 1MB online installer) will give the same message as Chrome's: "No update is available".

Regarding the other installers: I expect the behavior reported by @btlechowski and @kjozwiak to continue until we provide a fix. That is, our offline installers will continue to work* in the sense that they will install Brave. But Brave will not launch.

*: Until we change our installer. This can happen when we upgrade from Omaha 3 to 4.

Regarding ideas: I wonder what Chrome will do. Their official offline installer is still on CR 109. My hope is that they will implement a solution we can reuse. I'd be surprised if they just let Chrome crash the way CR 110 seems to be doing now.

@mherrmann there's some examples above of what Chrome does with it's stub installers. But I could never find their offline installers. Mind linking me? I'll download one for Canary and see what happens on Win 8.1. I didn't think Google provided offline executables. Only stub installers. Searched for a bit before and could never find anything other than offline installers that archive websites host which I'm always worried about download/using.

@mherrmann
Copy link

@kjozwiak I couldn't find offline installers for other channels. But for stable, I searched for "chrome offline installer", which took me here, which under "How to install Chrome" has a section "Install Chrome offline" with a download link.

@btlechowski
Copy link
Author

Verified on Nightly 1.49.x on Windows 7 x64

stub installer installs 1.49.60 Chromium: 109.0.5414.119 (Official Build) nightly (64-bit). c110 is not installed.
The c110 is installed on Windows 10 x64

image

Update to c110 is no offered for 1.49.60 Chromium: 109.0.5414.119 (Official Build) nightly (64-bit)

image

@btlechowski
Copy link
Author

Verified on Nightly 1.49.x on Windows 7 x86

stub installer installs 1.49.60 Chromium: 109.0.5414.119 (Official Build) nightly (32-bit) . c110 is not installed.

image

@kjozwiak
Copy link
Member

@btlechowski mind checking the above again? I think this was resolved with the latest C110 chromium. For example, I received a warning regarding not being able to install Brave as per #28511. The warning is incorrect and should say Win 10 or higher, but Brave didn't install like it did before as reported above.

@btlechowski
Copy link
Author

Verified fixed 1.48.164 c110

I get a message from standalone installer. Also reproduced #28511

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants