Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verified pubs shows up as not verified due to delay in fetching verified pubs list #2816

Closed
srirambv opened this issue Jan 4, 2019 · 24 comments

Comments

@srirambv
Copy link
Contributor

srirambv commented Jan 4, 2019

Description

Verified pubs shows up as not verified due to delay in fetching verified pubs list

Steps to Reproduce

  1. Start a clean profile
  2. Enable Rewards
  3. Before wallet is created, open a new tab and visit a verified pub site
  4. Click on BR panel, shows the pub is not verified
  5. Wait for a few seconds/mins until the list is downloaded, shows as verified in BR panel

Actual result:

screenshot from 2019-01-04 20-57-48

Expected result:

screenshot from 2019-01-04 20-58-02

Reproduces how often:

Easy

Brave version (brave://version info)

All

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
    N/A
  • Is the issue reproducible on the latest version of Chrome?
    N/A

Additional Information

@kjozwiak
Copy link
Member

kjozwiak commented Jan 4, 2019

@srirambv I believe we were running into this when we were releasing the 0.58.17 & 0.57.18 hotfixes during the holidays. Where it takes a bit of time to start showing which publishers were verified. @GeetaSarvadnya was also seeing the same thing during that time. After we waited several minutes, the information started appearing.

@NejcZdovc NejcZdovc removed their assignment Jan 5, 2019
@NejcZdovc NejcZdovc added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Jan 5, 2019
@iAlertServices
Copy link

Waiting several minutes doesn't correct the problem on my end. Waited multiple hours. Is there a target date when this will be fixed being this is a major user feature?

@kjozwiak
Copy link
Member

@iAlertServices there's currently no target date yet but the issue has been prioritized. Just a matter of a developer picking it up.

@GeetaSarvadnya
Copy link

@Sh1d0w
Copy link

Sh1d0w commented Jan 28, 2019

I have the same problem. It is actual a major issue, since I've verified one of my wbesites 2 weeks ago and it still shows as non verified.

I was advised to delete ~/Library/Application\ Support/BraveSoftware/Brave-Browser/Default/publishers_list after I deleted it and waited several hours to be re-downloaded the problem still exists.

If I open the file and search for my website it is there:

["XXXXXXXXXXX.com",true,false,{}]

But in Brave Rewards it shows as unverified, so I can not receive tips.

@kjozwiak
Copy link
Member

But in Brave Rewards it shows as unverified, so I can not receive tips.

@Sh1d0w you'll still be able to receive tips from other users that have an up to date publishers_list.

@Sh1d0w
Copy link

Sh1d0w commented Jan 28, 2019

@kjozwiak My point is I think there is a bug in Brave, since I've taken the steps to make my list up to date as it seems it was not updating automatically for some reason, but even then after refreshing the list and verifying the website is there, it still shows unverified.

@BrendanEich
Copy link
Member

Definitely a bug. @jonathansampson taking a look to see if devtools + code inspection can shed light.

@jonathansampson
Copy link
Contributor

jonathansampson commented Jan 30, 2019

@Sh1d0w I believe this is a separate issue. I was speaking with @NejcZdovc recently about this, and failure of the get_publisher() method to return appropriate publisher information. So even if your publishers_list is up to date, some properties may still experience this issue.

We're looking further into the problem now, and will provide an update when we have a lead.

@kjozwiak
Copy link
Member

kjozwiak commented Jan 30, 2019

@Sh1d0w yup, definitely aware of the issue regarding publishers lists sometimes not being pulled. Regarding the above comment, I just wanted to point out that even though you're having issues pulling the publishers list, you'll still be getting tips from other folks 👍

Are you still having the same issue? The list should be downloaded every 48hrs. If you're still having issues after 48hrs, it's most likely you're experiencing what @jonathansampson mentioned above.

@Sh1d0w
Copy link

Sh1d0w commented Jan 31, 2019

@jonathansampson Since it is happening to me atm, let me know if I can provide more info like the verified domain name or some other logs. I can send those via email if needed so you can check them and see if there is any clue?

@kjozwiak Yes I am still experiencing this. I've verified the website more than two weeks ago, removed the publishers_list a week ago, it got refreshed I can see the website is there now, but Brave still shows my website is not verified :( I am not sure if others can send tips tho, since I've re-downloaded the publisher list and still there is a problem.

Let me know if I can help in some way to identify the issue.

@jonathansampson
Copy link
Contributor

jonathansampson commented Jan 31, 2019

@Sh1d0w Would you be willing to download our developer preview and see if you experience the issue there as well? You can get it online at https://brave.com/download-dev. Installing it will not impact your primary Brave install.

Also, would you be up for a Skype call later to poke at your browser instance together? We might be able to spot some funny business by playing around in the developer tools a bit.

@Sh1d0w
Copy link

Sh1d0w commented Feb 1, 2019

@jonathansampson Sure I have the dev version installed long before it was released in the official channel. I've updated it to the latest dev, but unfortunately when trying to re - enable Brave Rewards I see:

screenshot 2019-02-01 at 6 05 49

I am ok for a Skype call, send me your Skype id to [email protected] and I will add you.

@jonathansampson
Copy link
Contributor

Thanks, @Sh1d0w. I've messed you on Skype and look forward to chatting soon.

@NejcZdovc
Copy link
Contributor

@Sh1d0w if you installed dev long time ago wallet was created on staging, where dev now points to production. You will need to create new wallet or run staging flag when you start browser. More info here https://github.com/brave/brave-browser/wiki/Rewards#flags

@jonathansampson
Copy link
Contributor

Following a call with @Sh1d0w and @NejcZdovc, it was determined that the site in question wasn't marked as verified in the publisher_info_db. After updating to 0.59.34 the issue was no longer reproducible.

@jonathansampson
Copy link
Contributor

Closing as it appears 0.59.34 resolves the issue.

@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Feb 1, 2019
@kjozwiak
Copy link
Member

kjozwiak commented Feb 2, 2019

@NejcZdovc out of curiosity, do we know which fix in 0.59.34 Chromium: 72.0.3626.81 might have fixed this?

@kjozwiak kjozwiak added closed/invalid and removed QA/Yes bug closed/not-actionable feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Feb 2, 2019
@Sh1d0w
Copy link

Sh1d0w commented Feb 2, 2019

@kjozwiak I am not completely sure this is fixed in 0.59.34

After I've updated to that version the site immediately became verified as it should, but maybe the DB update that was triggered was caused by the update itself?

I have second website that I've verified on 31st of Jan, today it still displays as unverified, just checked.

I see it is not present in publishers_list, so I again deleted it and will wait for it to refresh and see if it will show as verified once it does. But then this rises the question:

How frequently publishers_list get refreshed and do I have to delete it manually every time I verify a website? Last time had to wait two weeks before I've deleted it, so it can be re - downloaded?

cc @jonathansampson @NejcZdovc

@NejcZdovc
Copy link
Contributor

@Sh1d0w currently it's 48h, but that will be changed in 0.60 to 24h

@Sh1d0w
Copy link

Sh1d0w commented Feb 4, 2019

@NejcZdovc Today the list updated and the website appears as verified, so all good.

I guess the confusion comes because of the delay to refresh publishers_list maybe on the publishers website it needs to let you know that the website will appear as verified after up to XX hours, because regular users don't know how it works behind the scenes and may become confused too.

@jonathansampson
Copy link
Contributor

I do not think 59.34 resolved this, unless 59.35 regressed. I just ran into a domain today that was in the publisher_list, but marked as not verified in the publisher_info_db file. Reopening.

@NejcZdovc
Copy link
Contributor

closing as domain was not in publisher_list. When we updated publisher_list domain was marked as verified.

@Sh1d0w
Copy link

Sh1d0w commented Feb 14, 2019

As I expected there is a lot of confusion regarding the interval that publishers_list gets updated, so I want again to suggest considering putting that information somewhere visible in the publishers platform when verifying a channel. See some of the topics below.

https://www.reddit.com/r/brave_browser/comments/aqb3ff/verified_publisher_site_showing_as_not_verified/

https://www.reddit.com/r/BATProject/comments/aq8uyp/brave_rewards_says_site_not_verified_despite/

@rebron rebron removed this from the Dupe / Invalid / Not actionable milestone May 8, 2019
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Jun 3, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants