Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base::expected<>-style API to the "fetch balance" flow #28793

Closed
Miyayes opened this issue Feb 28, 2023 · 4 comments · Fixed by brave/brave-core#17480
Closed

Add base::expected<>-style API to the "fetch balance" flow #28793

Miyayes opened this issue Feb 28, 2023 · 4 comments · Fixed by brave/brave-core#17480
Assignees
Labels
feature/rewards needs-investigation A bug not 100% confirmed/fixed OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass-macOS QA/Yes release-notes/exclude

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Feb 28, 2023

Most important is balance related.

@Miyayes Miyayes added needs-investigation A bug not 100% confirmed/fixed priority/P3 The next thing for us to work on. It'll ride the trains. labels Mar 1, 2023
@szilardszaloki szilardszaloki added OS/Android Fixes related to Android browser functionality OS/iOS Fixes related to iOS browser functionality QA/Yes release-notes/exclude labels Mar 9, 2023
@brave-builds brave-builds added this to the 1.51.x - Nightly milestone Mar 10, 2023
@Miyayes
Copy link
Collaborator Author

Miyayes commented Mar 13, 2023

@szilardszaloki Would you be able to rename this issue to something more specific, now that you made some definite changes? :)

@szilardszaloki szilardszaloki changed the title Audit network errors and their UI effects Add base::expected<>-style API to the "fetch balance" flow Mar 13, 2023
@kjozwiak
Copy link
Member

The above requires 1.50.94 or higher for 1.50.x verification 👍

@LaurenWags
Copy link
Member

LaurenWags commented Mar 24, 2023

Verified with

Brave | 1.50.102 Chromium: 111.0.5563.116 (Official Build) beta (x86_64)
-- | --
Revision | ade86b9472831e26d87fd569e04b404be01e1e2b-refs/branch-heads/5563@{#1209}
OS | macOS Version 12.6.3 (Build 21G419)
1. Before enabling rewards - PASSED
  • Confirmed that there is no Balance info displayed on the brave://rewards-internals page before enabling the rewards
Screen Shot 2023-03-24 at 2 38 14 PM
2. After enabling rewards - PASSED
  • Confirmed that after enabling the rewards the vBAT balance is shown on the Rewards Internals page
  • Confirmed that the Connect account is shown on the brave://rewards settings page, BR panel and rewards NTP widget
Example Example Example Example
Screen Shot 2023-03-24 at 2 39 27 PM Screen Shot 2023-03-24 at 2 39 54 PM Screen Shot 2023-03-24 at 2 40 04 PM Screen Shot 2023-03-24 at 2 40 13 PM
3. After connecting a custodial wallet - PASSED
  • Confirmed that after connecting custodian wallet, both the vBAT/external wallet balance is displayed on the Rewards Internals page
  • Confirmed that after connecting custodian wallet, total balance is displayed on the Rewards page, Rewards panel and Rewards NTP widget
Example Example Example Example
Screen Shot 2023-03-24 at 2 43 47 PM Screen Shot 2023-03-24 at 2 43 53 PM Screen Shot 2023-03-24 at 2 44 02 PM Screen Shot 2023-03-24 at 2 44 08 PM
4. Logged out state - PASSED
  • Confirmed that in the logged out state,the vBAT balanceis shown only on the Rewards Internals page
  • Confirmed that Logged out UI is shown on the brave://rewards, BR panel, Rewards NTP and Tipping banner
  • Confirmed that : ( You are currently logged out text message is shown on the tipping banner
Example Example Example Example Example
Screen Shot 2023-03-24 at 2 46 20 PM Screen Shot 2023-03-24 at 2 46 30 PM Screen Shot 2023-03-24 at 2 46 39 PM Screen Shot 2023-03-24 at 2 46 46 PM Screen Shot 2023-03-24 at 2 47 00 PM
5. Fail the fetch balance request - PASSED
  • Uphold wallet (pre-req: have Charles Proxy set up to return 500 error for the endpoint (https://api-sandbox.uphold.com/v0/me/cards/*)
  • Confirmed that spinner animation is shown for both the Rewards BAT (vBAT) and external wallet balance on brave://rewards-internals page
Example Example Example Example
Screen Shot 2023-03-24 at 2 51 48 PM Screen Shot 2023-03-24 at 2 52 00 PM Screen Shot 2023-03-24 at 2 52 09 PM Screen Shot 2023-03-24 at 2 52 15 PM
6. Reset rewards - PASSED
  • Confirmed that after Reset rewards the wallet balance info is not displayed on the brave://rewards-internals page
Screen Shot 2023-03-24 at 2 54 13 PM

@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 28, 2023
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 28, 2023

Verification PASSED on Samsung Galaxy version 12 running Bravemonoarm64.apk_1.50.101

1. Before enabling rewards - PASSED
  • Confirmed that there is no Balance info displayed on the brave://rewards-internals page before enabling the rewards

Screenshot_20230328-170556_Brave - Beta

2. After enabling rewards - PASSED
  • Confirmed that after enabling the rewards the vBAT balance is shown on the Rewards Internals page
  • Confirmed that the Connect account is shown on the brave://rewards settings page, BR panel and rewards NTP widget (NA)
Example Example Example
Screenshot_20230328-170726_Brave - Beta Screenshot_20230328-170736_Brave - Beta Screenshot_20230328-170759_Brave - Beta
3. After connecting a custodial wallet - PASSED
  • Confirmed that after connecting custodian wallet, both the vBAT/external wallet balance is displayed on the Rewards Internals page
  • Confirmed that after connecting custodian wallet, total balance is displayed on the Rewards page, Rewards panel and Rewards NTP widget (NA)
Example Example Example
Screenshot_20230328-171222_Brave - Beta Screenshot_20230328-171233_Brave - Beta Screenshot_20230328-171240_Brave - Beta
4. Logged out state - logged #29361
Example Example Example Example
Screenshot_20230328-172339_Brave - Beta Screenshot_20230328-172311_Brave - Beta Screenshot_20230328-172320_Brave - Beta Screenshot_20230328-172449_Brave - Beta
5. Fail the fetch balance request - PASSED
Example Example Example
Screenshot_20230328-172831_Brave - Beta Screenshot_20230328-172842_Brave - Beta Screenshot_20230328-172908_Brave - Beta
6. Reset rewards - PASSED
  • Confirmed that after Reset rewards the wallet balance info is not displayed on the brave://rewards-internals page
Example Example
Screenshot_20230328-173022_Brave - Beta Screenshot_20230328-173009_Brave - Beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards needs-investigation A bug not 100% confirmed/fixed OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants