-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add base::expected<>
-style API to the "fetch balance" flow
#28793
Labels
feature/rewards
needs-investigation
A bug not 100% confirmed/fixed
OS/Android
Fixes related to Android browser functionality
OS/Desktop
OS/iOS
Fixes related to iOS browser functionality
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass - Android ARM
QA Pass-macOS
QA/Yes
release-notes/exclude
Milestone
Comments
Miyayes
added
needs-investigation
A bug not 100% confirmed/fixed
priority/P3
The next thing for us to work on. It'll ride the trains.
labels
Mar 1, 2023
25 tasks
szilardszaloki
added
OS/Android
Fixes related to Android browser functionality
OS/iOS
Fixes related to iOS browser functionality
QA/Yes
release-notes/exclude
labels
Mar 9, 2023
7 tasks
@szilardszaloki Would you be able to rename this issue to something more specific, now that you made some definite changes? :) |
szilardszaloki
changed the title
Audit network errors and their UI effects
Add Mar 13, 2023
base::expected<>
-style API to the "fetch balance" flow
The above requires |
Verified with
1. Before enabling rewards - PASSED
2. After enabling rewards - PASSED
3. After connecting a custodial wallet - PASSED
4. Logged out state - PASSED
5. Fail the fetch balance request - PASSED
|
GeetaSarvadnya
added
the
QA/In-Progress
Indicates that QA is currently in progress for that particular issue
label
Mar 28, 2023
Verification PASSED on
1. Before enabling rewards - PASSED
2. After enabling rewards - PASSED
3. After connecting a custodial wallet - PASSED
4. Logged out state - logged #29361
5. Fail the fetch balance request - PASSED
|
GeetaSarvadnya
added
QA Pass - Android ARM
and removed
QA/In-Progress
Indicates that QA is currently in progress for that particular issue
labels
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/rewards
needs-investigation
A bug not 100% confirmed/fixed
OS/Android
Fixes related to Android browser functionality
OS/Desktop
OS/iOS
Fixes related to iOS browser functionality
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass - Android ARM
QA Pass-macOS
QA/Yes
release-notes/exclude
Most important is balance related.
The text was updated successfully, but these errors were encountered: