Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flag to disable generating a namespace for Obj-C wrappers generated from mojom #29098

Closed
kylehickinson opened this issue Mar 15, 2023 · 0 comments · Fixed by brave/brave-core#17628
Closed

Add flag to disable generating a namespace for Obj-C wrappers generated from mojom #29098

kylehickinson opened this issue Mar 15, 2023 · 0 comments · Fixed by brave/brave-core#17628
Assignees
@kylehickinson
Labels
OS/iOS Fixes related to iOS browser functionality QA/No release-notes/exclude
Milestone
1.50.x - Release

Comments

@kylehickinson
Copy link
Collaborator

Description

We can end up with ambiguous namespaces because multiple namespaces with the same Swift name can be generated currently
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kylehickinson kylehickinson

Labels
OS/iOS Fixes related to iOS browser functionality QA/No release-notes/exclude
Projects
None yet
Milestone
1.50.x - Release
Development

Successfully merging a pull request may close this issue.

[iOS] Add flag to control namespace generation for Obj-C mojom wrappers brave/brave-core
3 participants
@kylehickinson @kjozwiak @brave-builds