Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NFT pinning not started after wallet reset until browser is restarted #29207

Closed
cypt4 opened this issue Mar 21, 2023 · 2 comments
Closed

NFT pinning not started after wallet reset until browser is restarted #29207

cypt4 opened this issue Mar 21, 2023 · 2 comments
Assignees
@cypt4
Labels
feature/web3/ipfs feature/web3/wallet/core feature/web3/wallet/nft feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.51.x - Release

Comments

@cypt4
Copy link

cypt4 commented Mar 21, 2023 •
edited
Loading

  1. Add several pinnable NFTs
  2. Reset wallet
  3. Add them again and enable NFT pinning
  4. Pinning won't start until browser is restarted
@cypt4 cypt4 self-assigned this Mar 21, 2023
@cypt4 cypt4 added feature/web3/ipfs feature/web3/wallet Integrating Ethereum+ wallet support release-notes/exclude priority/P4 Planned work. We expect to get to it "soon". labels Mar 21, 2023
@cypt4 cypt4 mentioned this issue Apr 12, 2023
Merged
25 tasks
@srirambv srirambv mentioned this issue Apr 17, 2023
Merged
7 tasks
@brave-builds brave-builds added this to the 1.51.x - Beta milestone Apr 18, 2023
@kjozwiak
Copy link
Member

Closing as I believe this was fixed via brave/brave-core#17983 and verified by @srirambv via brave/brave-core#17983 (comment). The above requires 1.51.95 or higher for 1.51.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.51.107 Chromium: 113.0.5672.63 (Official Build) (64-bit)
Revision 0e1a4471d5ae5bf128b1bd8f4d627c8cbd55f70c-refs/branch-heads/5672@{#912}
OS Windows 11 Version 22H2 (Build 22621.1555)
  • Verified steps from brave/brave-core#17983
  • Verified after resetting wallet newly added NFT in new wallet automatically starts pinning if the auto pin nft setting is enabled
29207.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cypt4 cypt4

Labels
feature/web3/ipfs feature/web3/wallet/core feature/web3/wallet/nft feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.51.x - Release
Development

No branches or pull requests
5 participants
@kjozwiak @HEagle18 @srirambv @brave-builds @cypt4