Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear pinned NFT doesn't have any UI feedback whether the reset worked or not #29554

Closed
srirambv opened this issue Apr 6, 2023 · 1 comment
Closed
Assignees
Labels
feature/web3/ipfs feature/web3/wallet/nft feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

srirambv commented Apr 6, 2023

Description

Clear pinned NFT doesn't have any UI feedback whether the reset worked or not

Steps to Reproduce

  1. Pin a few NFT's
  2. Disable Automatically pin NFTs setting
  3. Click on Clear pinned NFT, there is no UI feedback if the setting worked or not

Actual result:

Clear pinned NFT doesn't have any UI feedback whether the reset worked or not

Expected result:

Should show if the setting cleared NFT's successfully or not

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.52.17 Chromium: 112.0.5615.49 (Official Build) nightly (64-bit)
Revision bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS Windows 11 Version 22H2 (Build 23424.1000)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @cypt4 @kleantzogu @minkyeongshin @jamesmudgett

@jamesmudgett jamesmudgett added the priority/P3 The next thing for us to work on. It'll ride the trains. label Apr 14, 2023
@jamesmudgett jamesmudgett self-assigned this Apr 14, 2023
@HEagle18 HEagle18 added the priority/P4 Planned work. We expect to get to it "soon". label Apr 21, 2023
@josheleonard
Copy link

Closing. NFT pinning no longer supported as of brave/brave-core#23808

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/ipfs feature/web3/wallet/nft feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/exclude
Projects
Archived in project
Development

No branches or pull requests

4 participants