Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After tearing off a tab (Move tab to another window) in vertical tab minimized mode, unable to move/drop the tab back to original window #29876

Closed
MadhaviSeelam opened this issue Apr 20, 2023 · 2 comments

Comments

@MadhaviSeelam
Copy link

MadhaviSeelam commented Apr 20, 2023

Description

Found while testing #29692
In vertical tab view minimized mode, after selecting Move tab to another window option in context menu, tried to drop back to original window and sometimes I was able to but sometimes nothing happened. It wasn't a clean move and and when the tab moved back, partial title was shown. However, able to move back to original window in expanded mode.

Steps to Reproduce

  1. Install 1.51.95
  2. launch Brave
  3. visit abcnews.com
  4. enable vertical tabs in brave://flags
  5. enable Use vertical tabs in context menu
  6. add few more tabs
  7. right click on a tab and select Move tab to another window >> New window
  8. tried to drag back the tab to original window

Actual result:

Drag/move back didn't work always in minimized mode.

2023-04-19_17h29_28.mp4

Expected result:

Should be able to move back to original window as in expanded mode

Reproduces how often:

Easily

Brave version (brave://version info)

Brave | 1.51.95 Chromium: 112.0.5615.121 (Official Build) beta (64-bit)
-- | --
Revision | 39cc4e45904ae9f1741c4fbaa866e629c96f2268-refs/branch-heads/5615_51@{#8}
OS | Windows 11 Version 22H2 (Build 22621.1555)

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@rebron @sangwoo108

cc: @brave/qa-team

@sangwoo108
Copy link

sangwoo108 commented Apr 20, 2023

It looks like around 50 sec in the video is the problem. And this could be due to the same reason with #29836 - close button consumes the event. And again, in this case it's expected behavior. I believe we can't drag a tab with close button from horizontal tab strip either.

@MadhaviSeelam
Copy link
Author

Closing as I am not able to reproduce the issue

2023-05-30_09h17_08.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants