Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update wallet reset title #30005

Closed
Pavneet-Sing opened this issue Apr 26, 2023 · 4 comments · Fixed by brave/brave-core#18246
Closed

Update wallet reset title #30005

Pavneet-Sing opened this issue Apr 26, 2023 · 4 comments · Fixed by brave/brave-core#18246
Assignees
@Pavneet-Sing
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. privacy QA Pass - Android ARM QA Pass-Linux QA/Yes release-notes/include
Milestone
1.52.x - Release #7

Comments

@Pavneet-Sing
Copy link

Description

Update wallet reset title to Reset and clear wallet data as discussed here.
@Pavneet-Sing Pavneet-Sing added privacy QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Apr 26, 2023
@Pavneet-Sing Pavneet-Sing self-assigned this Apr 26, 2023
@Pavneet-Sing Pavneet-Sing added the priority/P3 The next thing for us to work on. It'll ride the trains. label Apr 26, 2023
@Pavneet-Sing Pavneet-Sing mentioned this issue Apr 26, 2023
Merged
25 tasks
@StephenHeaps StephenHeaps mentioned this issue Apr 26, 2023
Closed
@brave-builds brave-builds added this to the 1.53.x - Nightly milestone Apr 27, 2023
@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 13 running 1.53.94 x64 Beta build

  • Verified steps form brave/brave-core#18246
  • Verified reset wallet title is changed from Reset Brave Wallet to Reset and clear wallet data
Light Dark
image image

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.53.94 Chromium: 114.0.5735.133 (Official Build) beta (64-bit)
Revision fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS Windows 11 Version 22H2 (Build 22621.1848)
  • Verified steps from brave/brave-core#18246
  • Verified reset wallet title is changed from Reset Brave Wallet to Reset and clear wallet data
Dark Light
brave_EPRJKlAZ1a brave_XFXQQ5ASaS

@Pavneet-Sing Pavneet-Sing mentioned this issue Jul 5, 2023
Merged
7 tasks
@kjozwiak
Copy link
Member

kjozwiak commented Jul 5, 2023

The above requires 1.52.130 or higher for 1.52.x verification 👍 Removing the QA Pass label(s) as the above will need to be rechecked with 1.52.x.

@srirambv
Copy link
Contributor

srirambv commented Jul 6, 2023

Verification passed on

Brave 1.52.130 Chromium: 114.0.5735.198 (Official Build) (64-bit)
Revision c3029382d11c5f499e4fc317353a43d411a5ce1c-refs/branch-heads/5735@{#1394}
OS Linux
  • Verified steps from brave/brave-core#18246
  • Verified reset wallet title is changed from Reset Brave Wallet to Reset and clear wallet data
30005.mp4

Verification passed on Oppo Reno 5 with Android 13 running 1.52.130 x64 build

  • Verified steps from brave/brave-core#18246
  • Verified reset wallet title is changed from Reset Brave Wallet to Reset and clear wallet data
30005.mp4

@LaurenWags LaurenWags mentioned this issue Jul 6, 2023
Closed
@kjozwiak kjozwiak mentioned this issue Jul 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. privacy QA Pass - Android ARM QA Pass-Linux QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.52.x - Release #7
Development

Successfully merging a pull request may close this issue.

update wallet reset title brave/brave-core
4 participants
@kjozwiak @Pavneet-Sing @srirambv @brave-builds