Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

after group of bookmarks deleted on device2, deletion is not synced to device1 #3261

Closed
LaurenWags opened this issue Feb 7, 2019 · 3 comments

Comments

@LaurenWags
Copy link
Member

Description

I deleted a chunk (100) bookmarks on device2 and the bookmarks were not deleted on device1. However, deleting a chunk of bookmarks on device1 does delete the bookmarks on device2.

Steps to Reproduce

  1. Clean profiles using 0.59.35 on both laptops (I was syncing macOS <-> macOS)

  2. Designate one to be macOS1/device1. Import 5k bookmarks.
    brave_sortish_5000 - ordered.html.zip

  3. On the other device (macOS2/device2) import 1k bookmarks.
    brave_sortish_1000 -ordered.html.zip

  4. Start sync chain on macOS1 and join on macOS2.

  5. In about 10-15 minutes devices should be synced fully.

  6. On macOS2, drill into the 0-99 folder all the way down to the 1109 folder. Delete the first 100 bookmarks in this folder (1-100).

Actual result:

This bookmark deletion will never get synced to macOS1.
screen shot 2019-02-07 at 11 42 42 am

Expected result:

In the image above, 1-100 should not be there.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.59.35 Chromium: 72.0.3626.81 (Official Build) (64-bit)
Revision ac8b982e05014492d1bd7d317628a4f22a97ffa0-refs/branch-heads/3626@{#796}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

I took the STR a bit further and did the below, which worked successfully

  • On macOS1, drill into Imported folder and navigate to 1000-1099 folder.
  • Delete the first 50 bookmarks (1000-1050)
  • Wait 5 minutes, this deletion is synced to macOS2.
@AlexeyBarabash
Copy link
Contributor

Could not reproduce on 0.62.0 master, trying on 0.59.35 stable.

@AlexeyBarabash
Copy link
Contributor

Could not reproduce it on 0.59.35 also , but on step 5 devices were not synced completely in more than a hour, the last inner folder on device 2 had 3395 of 3956 bookmarks, 75-518 were missing. On example of bookmark 444 I could see device 1 had sent it, but device 2 had never received.

@AlexeyBarabash
Copy link
Contributor

I could not reproduce this issue:
image

Brave 0.65.44 Chromium: 74.0.3729.61 (Developer Build) (64-bit)
Revision 5df2c8936783bd7575987e45d72a92fcf528496b-refs/branch-heads/3729@{#645}
OS Linux

I think, it had been fixed by brave/sync#284.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants