Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Password Manager tab icon to match Brave brand #33242

Closed
Brave-Matt opened this issue Sep 25, 2023 · 9 comments · Fixed by brave/brave-core#20356
Closed

Change Password Manager tab icon to match Brave brand #33242

Brave-Matt opened this issue Sep 25, 2023 · 9 comments · Fixed by brave/brave-core#20356
Assignees
Labels
branding design A design change, especially one which needs input from the design team misc/icons OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/include

Comments

@Brave-Matt
Copy link

Description

The icon on the password manager tab looks like it was pulled straight from Chrome/Chromium — even through Chrome's does look slightly different (both shown below). The icon in the tab should match the rest of the Brave brand.

Icon in Brave:
image

Icon in Chrome:
image

@Brave-Matt Brave-Matt added design A design change, especially one which needs input from the design team misc/icons branding OS/Desktop labels Sep 25, 2023
@rebron
Copy link
Collaborator

rebron commented Sep 29, 2023

cc: @aguscruiz

@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. release-notes/include QA/Yes labels Sep 29, 2023
@aguscruiz
Copy link

@fallaciousreasoning we should use the same one we have in the menu here 👀

@fallaciousreasoning
Copy link

The one in the menu looks a little odd next to our other icons, as it doesn't have much height and looks a wee bit small:
image

Do you think the key-lock icon is better?
https://nala.bravesoftware.com/icons/key-lock.svg

@fallaciousreasoning
Copy link

I also feel like it doesn't look great as an installed app icon:
image

@fallaciousreasoning
Copy link

Just to prove I'm not and should never be a designer, what about something like this:
image

(I'm using the release gradient for the background --leo-gradient-brave-release)

@aguscruiz
Copy link

Ugh, I didn't know you could install it as a web app and it'd look THAT big hah. I think the one in the tab is ok. But I'll have to spend more time with the big one.

I'll put it in my backlog for now, is that ok?

@fallaciousreasoning
Copy link

@aguscruiz's much nicer icon:
PWA Icon

@fallaciousreasoning
Copy link

Exported the wrong layer - actual icon is this:
Password manager

@rebron rebron assigned fallaciousreasoning and unassigned rebron Oct 17, 2023
@brave-builds brave-builds added this to the 1.62.x - Nightly milestone Nov 13, 2023
@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Nov 14, 2023
@stephendonner
Copy link

Verification PASSED using

Brave | 1.62.52 Chromium: 119.0.6045.134 (Official Build) nightly (x86_64)
-- | --
Revision | f73c8c1e096256f71307b56c8f7180fc85028d85
OS | macOS Version 11.7.10 (Build 20G1427)

Confirmed the new key icon is very "Bravey", in all the places I knew to check

Install app? prompt brave://settings/autofill brave://settings/autofill brave://password-manager/passwords brave://password-manager/passwords
Screen Shot 2023-11-14 at 1 34 14 PM Screen Shot 2023-11-14 at 1 34 55 PM Screen Shot 2023-11-14 at 1 35 11 PM Screen Shot 2023-11-14 at 1 43 01 PM Screen Shot 2023-11-14 at 1 43 17 PM
Key icon Finder icon
Screen Shot 2023-11-14 at 1 34 42 PM Screen Shot 2023-11-14 at 1 36 01 PM

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branding design A design change, especially one which needs input from the design team misc/icons OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants