Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkboxes should use Brave color palette #3377

Closed
petemill opened this issue Feb 15, 2019 · 1 comment · Fixed by brave/brave-core#1422
Closed

Checkboxes should use Brave color palette #3377

petemill opened this issue Feb 15, 2019 · 1 comment · Fixed by brave/brave-core#1422
Assignees
@petemill
Labels
QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include web-ui
Milestone
0.63.x - Release ...

Comments

@petemill
Copy link
Member

Chromium webui pages all use material color palette for checkboxes. These should use brave color palette.

Test plan

Check a checkbox on the left of any history item in chrome://history.
@petemill petemill self-assigned this Feb 15, 2019
@petemill petemill mentioned this issue Feb 15, 2019
Merged
21 tasks
@bsclifton bsclifton added this to the 0.63.x - Nightly milestone Feb 22, 2019
@LaurenWags
Copy link
Member

LaurenWags commented Mar 25, 2019 •
edited by srirambv
Loading

Verified passed with

Brave 0.63.21 Chromium: 73.0.3683.75 (Official Build) dev(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Mac OS X

Verification passed on

Brave 0.63.20 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Windows 10 OS Build 17134.523

image

Verification passed on

Brave 0.63.20 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Linux

image

@kjozwiak kjozwiak mentioned this issue Apr 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petemill petemill

Labels
QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include web-ui
Projects
None yet
Milestone
0.63.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

WebUI: Navigation Bar and other webui overhaul brave/brave-core
5 participants
@petemill @bsclifton @srirambv @LaurenWags @btlechowski