Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Placeholder Icons for Broken NFT images #34139

Closed
Douglashdaniel opened this issue Nov 6, 2023 · 1 comment · Fixed by brave/brave-core#20859
Closed

Add Placeholder Icons for Broken NFT images #34139

Douglashdaniel opened this issue Nov 6, 2023 · 1 comment · Fixed by brave/brave-core#20859
Assignees
@Douglashdaniel
Labels
enhancement feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.62.x - Release

Comments

@Douglashdaniel
Copy link

Description

We need to implement a Placeholder icon for broken NFT images

Screenshot 53

Screenshot 54
@Douglashdaniel Douglashdaniel added enhancement QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Nov 6, 2023
@Douglashdaniel Douglashdaniel self-assigned this Nov 6, 2023
@Douglashdaniel Douglashdaniel mentioned this issue Nov 6, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.62.x - Nightly milestone Nov 7, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.62.130 Chromium: 120.0.6099.199 (Official Build) beta (64-bit)
Revision 6d589c6dc0f3489830d40332c82cdd5597e41c88
OS Windows 11 Version 23H2 (Build 22631.2861)
  • Verified steps from brave/brave-core#20859
  • Verified NFT placeholder icon is shown for NFTs with broken images
    brave_GBzMR82vL9

Verification passed on

Brave 1.62.130 Chromium: 120.0.6099.199 (Official Build) beta (64-bit)
Revision 6d589c6dc0f3489830d40332c82cdd5597e41c88
OS Linux
  • Verified steps from brave/brave-core#20859
  • Verified NFT placeholder icon is shown for NFTs with broken images
    NFTPlaceholder

Verification passed on

Brave 1.62.130 Chromium: 120.0.6099.199 (Official Build) beta (arm64)
Revision 6d589c6dc0f3489830d40332c82cdd5597e41c88
OS macOS Version 14.2.1 (Build 23C71)
  • Verified steps from brave/brave-core#20859
  • Verified NFT placeholder icon is shown for NFTs with broken images
    image

@LaurenWags LaurenWags mentioned this issue Jan 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
enhancement feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.62.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): NFT Placeholder Icon brave/brave-core
3 participants
@srirambv @Douglashdaniel @brave-builds