Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add primary language P3A metric #34853

Closed
DJAndries opened this issue Dec 12, 2023 · 2 comments · Fixed by brave/brave-core#21355
Closed

Add primary language P3A metric #34853

DJAndries opened this issue Dec 12, 2023 · 2 comments · Fixed by brave/brave-core#21355
Assignees
Labels
feature/new-metric Proposing a new metric for Privacy Preserving Product Analytics (P3A) features/P3A OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/exclude

Comments

@DJAndries
Copy link
Collaborator

DJAndries commented Dec 12, 2023

Add a monthly P3A metric for the user's primary language:

What is your primary language?
Brave.Core.PrimaryLang

List of answers defined in components/misc_metrics/language_metrics.cc

Only available via STAR/Constellation.

cc @AndyAnds265

@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.64.90 Chromium: 122.0.6261.94 (Official Build) beta (64-bit)
-- | --
Revision | 726c6970a1e9c057c69d80e03ad95a7c561fbfe7
OS | Windows 10 Version 22H2 (Build 19045.4046)
Example Example
image image

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 6, 2024
@hffvld
Copy link
Contributor

hffvld commented Mar 6, 2024

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 14 AP21.240119.009 release-keys
Brave build: 1.64.95
Chromium: 122.0.6261.94 (Official Build) beta (64-bit)

STEPS:

  1. Follow the steps from Add primary language metric brave-core#21355 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that the metrics Brave.Core.PrimaryLang is shown under logs_constellation_prep_slow block

English Russian Spanish Japanise Hebrew
1 2 3 4 5
1 2 3 4 5
1 2 3 4 5

@hffvld hffvld added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/new-metric Proposing a new metric for Privacy Preserving Product Analytics (P3A) features/P3A OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants