Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to click Reload on a just-added direct feed to populate it #35000

Closed
stephendonner opened this issue Dec 20, 2023 · 5 comments · Fixed by brave/brave-core#21439
Closed

Comments

@stephendonner
Copy link

Description

Need to click Reload on a just-added direct feed to populate it

Steps to Reproduce

  1. install 1.63.56
  2. launch Brave
  3. open a new-tab page
  4. scroll down
  5. click on Turn on Brave News
  6. load https://chriscoyier.net/
  7. clicked on Manage Subscriptions
  8. clicked Subscribe
  9. close the Customize dialog
  10. click on Chris Coyer under Publishers
  11. look at the feed

Actual result:

example example
Screenshot 2023-12-20 at 12 40 48 PM Screenshot 2023-12-20 at 12 41 19 PM

Expected result:

Screenshot 2023-12-20 at 12 41 29 PM

Since we've just added the feed, it should either be populated or pop-up a New content available. Reload? message or similar?

Reproduces how often:

100%

Brave version (brave://version info)

Brave | 1.63.56 Chromium: 120.0.6099.115 (Official Build) nightly (x86_64)
-- | --
Revision | 9822b7ef57464ac11d27d48c164ca5e0780d1e1f
OS | macOS Version 14.3 (Build 23D5033f)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @fallaciousreasoning @LorenzoMinto @mattmcalister @rebron @brave/qa-team

@kjozwiak
Copy link
Member

The above requires 1.62.124 or higher for 1.62.x verification 👍

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jan 2, 2024

Verification PASSED on

Brave | 1.62.128 Chromium: 120.0.6099.144 (Official Build) beta (64-bit)
-- | --
Revision | 41f5844c06c7db1017f39b5b6dc9ba81a6b1b9d6
OS | Windows 10 Version 22H2 (Build 19045.3803)
  • Verified the STR from the description and ensured that when a new content is subscribe the New content available. Reload? message is shown

Brave news

@stephendonner
Copy link
Author

stephendonner commented Jan 3, 2024

Thanks for taking a look at this, @GeetaSarvadnya.

Here's what I'm still seeing, using

Brave | 1.63.87 Chromium: 120.0.6099.144 (Official Build) nightly (x86_64)
-- | --
Revision | 98ef7c0500de982c1d636266944146b3ecd52cf5
OS | macOS Version 14.3 (Build 23D5033f)

chriscoyier-feed

@fallaciousreasoning do we need a separate followup issue for the above?

@fallaciousreasoning
Copy link

Yeah, I think a separate issue is a good call!

@stephendonner
Copy link
Author

Yeah, I think a separate issue is a good call!

Logged #35096.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment