Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ads] Optimize javascript requests for non rewards users #35205

Closed
aseren opened this issue Jan 9, 2024 · 2 comments · Fixed by brave/brave-core#21529
Closed

[ads] Optimize javascript requests for non rewards users #35205

aseren opened this issue Jan 9, 2024 · 2 comments · Fixed by brave/brave-core#21529
Assignees
@aseren
Labels
enhancement feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/exclude
Milestone
1.63.x - Release

Comments

@aseren
Copy link

aseren commented Jan 9, 2024

No description provided.

@aseren aseren self-assigned this Jan 9, 2024
@aseren aseren mentioned this issue Jan 9, 2024
Merged
24 tasks
@aseren aseren added QA/Yes and removed QA/Yes labels Jan 9, 2024
@tmancey tmancey added QA/Yes priority/P3 The next thing for us to work on. It'll ride the trains. labels Jan 9, 2024
@tmancey tmancey mentioned this issue Jan 9, 2024
Open
@brave-builds brave-builds added this to the 1.63.x - Nightly milestone Jan 10, 2024
@btlechowski
Copy link

btlechowski commented Feb 12, 2024 •
edited
Loading

Verified with

Brave 1.63.149 Chromium: 121.0.6167.164 (Official Build) beta (64-bit)
Revision 16509c04a66afcc00d180c0b62a887b9fc4776a2
OS Linux

Verified test plan from brave/brave-core#21529

Fresh profile

Verified Tab id HTML content changed is in the logs:

[21966:21966:0222/034543.235060:VERBOSE2:tab_manager.cc(150)] Tab id 1420920269 HTML content changed

Verified Tab id text content changed is not in the logs:

Joined rewards

Verified Tab id HTML content changed is in the logs:

[21966:21966:0222/034703.753590:VERBOSE2:tab_manager.cc(150)] Tab id 1420920270 HTML content changed

Verified Tab id text content changed is in the logs:

[21966:21966:0222/034703.769532:VERBOSE2:tab_manager.cc(165)] Tab id 1420920270 text content changed

@bridiver
Copy link
Contributor

bridiver commented Jun 9, 2024

#34919 was closed as a duplicate of this, but this issue provides no information at all about what we're doing here and it doesn't appear to actually resolve the issues brought up in #34919 because it's still calling XMLSerializer on every page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aseren aseren

Labels
enhancement feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.63.x - Release
Development

Successfully merging a pull request may close this issue.

Optimize brave ads javascript requests for non rewards users brave/brave-core
5 participants
@bridiver @tmancey @btlechowski @brave-builds @aseren