Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Sync Server Option (Flag or Setting rather than Command Line Arg) #37448

Open
NicholasFlamy opened this issue Apr 10, 2024 · 0 comments
Open
Labels
feature/settings feature/sync OS/Android Fixes related to Android browser functionality OS/Desktop

Comments

@NicholasFlamy
Copy link

This is a replacement for the now-hidden #12314

Description

The only way to set a custom sync server URL is with a command line argument which is not a proper solution, but rather a feature for developer testing. (Including unreliability in the case of a crash and self-restart it won't be applied.) It is also not a solution because on non-rooted Android you have to enable "Enable command line on non-rooted devices" which makes an annoying popup every launch/New Tab opened. iOS doesn't even have a way to use command-line arguments.

So, I propose either a setting within the sync settings to change the sync server URL or a flag. @Fmstrat (https://github.com/Fmstrat/brave-core/tree/feature/custom-flag-sync-server) had a supposedly working solution, one with a GUI option and one with a flag. I have been attempting to create a build with a flag for this but have not quite gotten there. My progress: https://github.com/flamy-brave

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/settings feature/sync OS/Android Fixes related to Android browser functionality OS/Desktop
Projects
None yet
Development

No branches or pull requests

2 participants