Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please delete #3751

Closed
ghost opened this issue Mar 16, 2019 · 25 comments · Fixed by brave/brave-core#2639
Closed

please delete #3751

ghost opened this issue Mar 16, 2019 · 25 comments · Fixed by brave/brave-core#2639
Assignees
Labels
design A design change, especially one which needs input from the design team feature/autoplay priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include

Comments

@ghost
Copy link

ghost commented Mar 16, 2019

please delete

@wakamex
Copy link

wakamex commented Mar 20, 2019

this is more annoying than allowing autoplay. it triggers every time i switch channels or tab back to discord.

@srirambv
Copy link
Contributor

@rebron I thought this issue was related to #1120 but looks like the user wants to hide the autoplay notification all together unless specified. I do feel this is a little distracting when you visit a site and default action is to stop autoplay. May be we can just show the icon and not the text? I

@srirambv srirambv added suggestion design A design change, especially one which needs input from the design team feature/autoplay priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Mar 25, 2019
@srirambv srirambv removed their assignment Mar 25, 2019
@rebron rebron removed the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Mar 27, 2019
@Brave-Matt
Copy link

For what it's worth, I think this message should be present or at least easily displayed whenever autoplay is blocked -- even if it's not in the address bar as it is now. Landing on a page to see all video content "frozen" can often look like an issue rather than the effect a particular setting.

I believe I've actually assisted a user in this exact situation - thinking that there was a web compat. issue with a site they were on when in reality, video and gif content autoplay was blocked and allowing it for the site resolved the issue.

Basically, I think its important that users still have easy access to any/all actions taken by Brave for any site. cc @rebron about moving notifications like this into Shields panel.

@Brave-Matt
Copy link

@Brave-Matt
Copy link

@Brave-Matt
Copy link

@dchawisher
Copy link

+1 from me. I just switched from Firefox because of the extension issue. The biggest difficulty with the transition has been that irritating notification.

@nicholasdtc
Copy link

Any news on this? Maybe a simple setting to disable it? It's really getting on my nerves now.

@npierno
Copy link

npierno commented May 6, 2019

+1!!! This is the only thing keeping me from switching to Brave full time.

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label May 6, 2019
@rebron rebron removed the suggestion label May 29, 2019
@den1k
Copy link

den1k commented Jun 4, 2019

+1 just installed brave and love it but agree with the sentiments above: this is overly generous notification UX for a mostly insignificant signal

@Brave-Matt
Copy link

@crifat
Copy link

crifat commented Jun 4, 2019

+1 at least remove the animation and keep the full text if needed.

@rossmoody rossmoody removed their assignment Jun 4, 2019
@hello-jason
Copy link

The solution here solves the annoying issue for me.

image

@simonhong simonhong self-assigned this Jun 6, 2019
@simonhong simonhong added the QA/No label Jun 7, 2019
@simonhong
Copy link
Member

@rebron All other content settings also have same issue. Do we only want to hide autoplay animation?

@rebron
Copy link
Collaborator

rebron commented Jun 7, 2019

I think we're only doing the sliding notification part for autoplay though. All the other content settings don't have a slide out.

@simonhong
Copy link
Member

simonhong commented Jun 7, 2019

@rebron No, you can also see slide animation for flash plugin - https://www.ultrasounds.com/

@rebron
Copy link
Collaborator

rebron commented Jun 10, 2019

@simonhong Ok. Let's take care of it for all cases. Autoplay, flash, any other ones that we're missing?

@simonhong
Copy link
Member

simonhong commented Jun 10, 2019

@rebron According to the implementation, all content settings model that blocked_explanatory_text_id can show slide animation.
They are flash, ads, automatic download, redirect and popup.

@adamreisnz
Copy link

Glad to see movement on this issue. Just switched to try out Brave, but this message popping up every time I navigated within Intercom was enough to drive me back to Chrome.

To be honest I don't even understand why it's triggering, as there are no video elements on the Intercom page as far as I could see.

@simonhong
Copy link
Member

simonhong commented Jun 11, 2019

@adamreisnz I think that page has some video elements like below.
Screen Shot 2019-06-11 at 10 52 53 AM

@adamreisnz
Copy link

adamreisnz commented Jun 11, 2019

@simonhong it's not on the intercom marketing website, it's inside the app. I've looked around the page and source, but there are no video's there as far as I can see.

@sanford
Copy link

sanford commented Jul 2, 2019

Is this in 65.121?? Still getting this message in every Reddit tab I scroll (multiple times per scroll).

@the-4-limbos
Copy link

the-4-limbos commented Jul 15, 2019

Brave is up to date
Version 0.66.99 Chromium: 75.0.3770.100 (Official Build) (64-bit)

it is still in this version. Any ETA on when the sliding notification will be removed and replaced with an icon like the shield button next to it?

thank you and keep up the good work :)

P.S. lol brave even blocks 3 trackers on github :p

https://api.github.com/_private/browser/stats

Annotation 2019-07-15 040053

@simonhong
Copy link
Member

@sanford @the-4-limbos It is in dev channel (0.68.x) now :)
We are planning to release 0.68 as a stable at August 20, 2019.
Thanks for checking!

@btlechowski
Copy link

btlechowski commented Aug 9, 2019

Verification passed on

Brave 0.68.120 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Windows 10 OS Version 1809 (Build 17763.379)

Logged a serious regression #5605

Verification passed on

Brave 0.68.128 Chromium: 76.0.3809.100 (Official Build) beta (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Ubuntu 18.04 LTS

Verified passed with

Brave 0.68.130 Chromium: 76.0.3809.100 (Official Build) (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Mac OS X

@ghost ghost changed the title Prevent sliding notification animation in omnibar for autoplay blocks. please delete Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/autoplay priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.