[Follow up to #22849] Improve URL bar state when opening an App Store link from another app

[hffvld]

Description:

Follow-up to #22849

Steps to Reproduce

1. Open Brave > Go to any website, for example Wikipedia.org
2. Close Brave
3. Open any other browser (Safari, Chrome, etc.) > Go to www.apple.com
4. Search for any app, for example Whatsapp
5. Tap and hold > Share... > Choose Brave
6. Tap Don't Allow > Observe

OR

1. Launch Brave > Go to www.apple.com
2. Search for any app, for example Whatsapp
3. Close and relaunch Brave
4. Wait for the transfer to App Store
5. Return to Brave > Observe

Actual result:

Observed Your connection to this site is not secure on the transition page when opening the App Store link from other app.

2024-04-11_16-23-21.mp4

2024-04-11_17-02-41.mp4

Expected result:

Improve the not secure cert state on the transition page when opening the App Store link from another app

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced

Brave Version:

Brave build: 1.67 (2)
BraveCore: 1.67.2 (124.0.6367.29)

• Can you reproduce this issue with the most recent build from TestFlight? YES
• Can you reproduce this issue with the previous version of the current build from TestFlight? YES
• Can you reproduce this issue with the current build from AppStore? YES

Device details:

iPhone 14 / iOS 17.5

Website problems only:

• Does the issue resolve itself when disabling Brave Shields?
• Is the issue reproducible on the latest version of Mobile Safari?

Additional Information

[kylehickinson]

To clarify this will occur when we cancel a provisional load when there is no NTP to fall back on. Since the web view doesn't have any committed URL we don't have anything to revert back to. We have a few options to solve this:

• Close the empty tab
• Clean up the URL bar in empty tab state and leave it in an about:blank state
• Load an NTP by default in the back/forward history somehow before actually loading external URLs