Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ads] Only call AdsTabHelper::MaybeNotifyTabHtmlContentDidChange for URL redirect chains that match view-through or click-through conversions #38497

Open
tmancey opened this issue May 22, 2024 · 2 comments
Labels
dev-concern feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality perf

Comments

@tmancey
Copy link
Contributor

tmancey commented May 22, 2024

Platforms

all

Description

Only call AdsTabHelper::MaybeNotifyTabHtmlContentDidChange for URL redirect chains that match a view-through or click-through conversion for viewed ads so that we do not executenew XMLSerializer().serializeToString(document) for every page.

@tmancey tmancey added priority/P3 The next thing for us to work on. It'll ride the trains. perf dev-concern QA/Yes release-notes/exclude feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality labels May 22, 2024
@tmancey tmancey changed the title [ads] Only execute MaybeNotifyTabHtmlContentDidChange() if the creative set conversion URL pattern matches the redirect chain [ads] Only execute AdsTabHelper::MaybeNotifyTabHtmlContentDidChange() for URL redirect chains that match a conversion May 22, 2024
@tmancey tmancey changed the title [ads] Only execute AdsTabHelper::MaybeNotifyTabHtmlContentDidChange() for URL redirect chains that match a conversion [ads] Only call AdsTabHelper::MaybeNotifyTabHtmlContentDidChange() for URL redirect chains that match a conversion May 22, 2024
@tmancey tmancey changed the title [ads] Only call AdsTabHelper::MaybeNotifyTabHtmlContentDidChange() for URL redirect chains that match a conversion [ads] Only call AdsTabHelper::MaybeNotifyTabHtmlContentDidChange for URL redirect chains that match a conversion May 22, 2024
@tmancey tmancey changed the title [ads] Only call AdsTabHelper::MaybeNotifyTabHtmlContentDidChange for URL redirect chains that match a conversion [ads] Only call AdsTabHelper::MaybeNotifyTabHtmlContentDidChange for URL redirect chains that match a conversion for viewed ads May 22, 2024
@atuchin-m
Copy link
Contributor

atuchin-m commented May 22, 2024

@tmancey could we explicitly describe the expected result?
no new XMLSerializer().serializeToString(document) inject to regular pages.

@tmancey tmancey self-assigned this May 22, 2024
@tmancey tmancey changed the title [ads] Only call AdsTabHelper::MaybeNotifyTabHtmlContentDidChange for URL redirect chains that match a conversion for viewed ads [ads] Only call AdsTabHelper::MaybeNotifyTabHtmlContentDidChange for URL redirect chains that match view-through or click-through conversions May 28, 2024
@tmancey tmancey changed the title [ads] Only call AdsTabHelper::MaybeNotifyTabHtmlContentDidChange for URL redirect chains that match view-through or click-through conversions [ads] Only call AdsTabHelper::MaybeNotifyTabHtmlContentDidChange for URL redirect chains that match view-through or click-through verifiable conversions Jun 3, 2024
@tmancey tmancey added the blocked label Jun 6, 2024
@tmancey
Copy link
Contributor Author

tmancey commented Jun 6, 2024

Blocked awaiting #38794

@tmancey tmancey removed priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude labels Jun 10, 2024
@tmancey tmancey changed the title [ads] Only call AdsTabHelper::MaybeNotifyTabHtmlContentDidChange for URL redirect chains that match view-through or click-through verifiable conversions [ads] Only call AdsTabHelper::MaybeNotifyTabHtmlContentDidChange for URL redirect chains that match view-through or click-through conversions Jun 11, 2024
@tmancey tmancey removed their assignment Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-concern feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality perf
Projects
Status: Dev Concern ❤️
Development

No branches or pull requests

2 participants