-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ads] Only call AdsTabHelper::MaybeNotifyTabHtmlContentDidChange
for URL redirect chains that match view-through or click-through conversions
#38497
Labels
dev-concern
feature/ads
OS/Android
Fixes related to Android browser functionality
OS/Desktop
OS/iOS
Fixes related to iOS browser functionality
perf
Comments
tmancey
added
priority/P3
The next thing for us to work on. It'll ride the trains.
perf
dev-concern
QA/Yes
release-notes/exclude
feature/ads
OS/Android
Fixes related to Android browser functionality
OS/Desktop
OS/iOS
Fixes related to iOS browser functionality
labels
May 22, 2024
tmancey
changed the title
[ads] Only execute
[ads] Only execute May 22, 2024
MaybeNotifyTabHtmlContentDidChange()
if the creative set conversion URL pattern matches the redirect chainAdsTabHelper::MaybeNotifyTabHtmlContentDidChange()
for URL redirect chains that match a conversion
tmancey
changed the title
[ads] Only execute
[ads] Only call May 22, 2024
AdsTabHelper::MaybeNotifyTabHtmlContentDidChange()
for URL redirect chains that match a conversionAdsTabHelper::MaybeNotifyTabHtmlContentDidChange()
for URL redirect chains that match a conversion
tmancey
changed the title
[ads] Only call
[ads] Only call May 22, 2024
AdsTabHelper::MaybeNotifyTabHtmlContentDidChange()
for URL redirect chains that match a conversionAdsTabHelper::MaybeNotifyTabHtmlContentDidChange
for URL redirect chains that match a conversion
tmancey
changed the title
[ads] Only call
[ads] Only call May 22, 2024
AdsTabHelper::MaybeNotifyTabHtmlContentDidChange
for URL redirect chains that match a conversionAdsTabHelper::MaybeNotifyTabHtmlContentDidChange
for URL redirect chains that match a conversion for viewed ads
@tmancey could we explicitly describe the expected result? |
tmancey
changed the title
[ads] Only call
[ads] Only call May 28, 2024
AdsTabHelper::MaybeNotifyTabHtmlContentDidChange
for URL redirect chains that match a conversion for viewed adsAdsTabHelper::MaybeNotifyTabHtmlContentDidChange
for URL redirect chains that match view-through or click-through conversions
tmancey
changed the title
[ads] Only call
[ads] Only call Jun 3, 2024
AdsTabHelper::MaybeNotifyTabHtmlContentDidChange
for URL redirect chains that match view-through or click-through conversionsAdsTabHelper::MaybeNotifyTabHtmlContentDidChange
for URL redirect chains that match view-through or click-through verifiable conversions
Blocked awaiting #38794 |
tmancey
removed
priority/P3
The next thing for us to work on. It'll ride the trains.
QA/Yes
release-notes/exclude
labels
Jun 10, 2024
tmancey
changed the title
[ads] Only call
[ads] Only call Jun 11, 2024
AdsTabHelper::MaybeNotifyTabHtmlContentDidChange
for URL redirect chains that match view-through or click-through verifiable conversionsAdsTabHelper::MaybeNotifyTabHtmlContentDidChange
for URL redirect chains that match view-through or click-through conversions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dev-concern
feature/ads
OS/Android
Fixes related to Android browser functionality
OS/Desktop
OS/iOS
Fixes related to iOS browser functionality
perf
Platforms
all
Description
Only call
AdsTabHelper::MaybeNotifyTabHtmlContentDidChange
for URL redirect chains that match a view-through or click-through conversion for viewed ads so that we do not executenew XMLSerializer().serializeToString(document)
for every page.The text was updated successfully, but these errors were encountered: