Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shields is no longer dark #3870

Closed
cezaraugusto opened this issue Mar 24, 2019 · 1 comment · Fixed by brave/brave-core#2084
Closed

Shields is no longer dark #3870

cezaraugusto opened this issue Mar 24, 2019 · 1 comment · Fixed by brave/brave-core#2084

Comments

@cezaraugusto
Copy link
Contributor

cezaraugusto commented Mar 24, 2019

brave/brave-core#1931 changed Shields UI from always-dark to always-light. We want to make sure that this reaches release without this theme change. Either make it always-dark or, preferrably, make it switch depending on browser / OS theme-type choice (dark or light).

Test Plan:

  1. Go to chrome://settings/appearance
  2. Switch theme
  3. Change active tab to an http(s) site
  4. Open shields

Expected: Shields should match whether dark/light theme was selected in Settings
Actual: Shields is only ever light

@btlechowski
Copy link

btlechowski commented Apr 25, 2019

Verification passed on

Brave 0.64.60 Chromium: 74.0.3729.91 (Official Build) beta (64-bit)
Revision 03844ed83e02b8add3f4b9cb859a7108d55b2e4d-refs/branch-heads/3729@{#860}
OS Windows 10 OS Build 17134.523

Used test plan from the description.

Verification passed on

Brave 0.62.50 Chromium: 73.0.3683.86 (Official Build) (64-bit)
Revision f9b0bec6063ea50ce2b71f5b9abbae7beee319a6-refs/branch-heads/3683@{#858}
OS Linux
  • Verified the STR mentioned in the description

Verified passed with

Brave 0.64.62 Chromium: 74.0.3729.108 (Official Build) beta(64-bit)
Revision daaff52abef89988bf2a26091062160b1482b108-refs/branch-heads/3729@{#901}
OS Mac OS X
  • Verified STR from description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment