Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to crlsets connects to storage.googleapis on windows #3920

Closed
jumde opened this issue Mar 28, 2019 · 2 comments · Fixed by brave/brave-core#2114
Closed

Update to crlsets connects to storage.googleapis on windows #3920

jumde opened this issue Mar 28, 2019 · 2 comments · Fixed by brave/brave-core#2114

Comments

@jumde
Copy link
Contributor

jumde commented Mar 28, 2019

Description

With v.5056 crlsets components downloads resources from storage.googleapis.com. Proxy requests for the resources through redirector.

Test Plan specified here: brave/brave-core#2114

@jumde jumde added the privacy/connect This requires making a network connection to a third-party service. label Mar 28, 2019
@jumde jumde self-assigned this Mar 28, 2019
@jumde
Copy link
Contributor Author

jumde commented Mar 28, 2019

NETWORK AUDIT FAIL: http://storage.googleapis.com/update-delta/hfnkpimlhhgieaddgfemjhofmfblmnib/5056/5055/9bcb5f1d3982dec2714603514c06afba60be66683de82367d19a8b8a423bd7d5.crxd
19:48:13  NETWORK AUDIT FAIL: http://storage.googleapis.com/update-delta/hfnkpimlhhgieaddgfemjhofmfblmnib/5056/5055/9bcb5f1d3982dec2714603514c06afba60be66683de82367d19a8b8a423bd7d5.crxd
19:48:13  network-audit failed. import C:\jenkins\workspace\brave-browser-build-pr_pj\network_log.json in chrome://net-internals

@LaurenWags
Copy link
Member

LaurenWags commented May 20, 2019

Verified passed with

Brave 0.65.97 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Mac OS X

Verification passed on

Brave 0.65.98 Chromium: 74.0.3729.131 (Official Build) beta (64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Windows 10 OS Build 17134.523

Connections made: brave_connections.txt

Verification passed on

Brave 0.65.113 Chromium: 75.0.3770.38 (Official Build) beta(64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Linux

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment