Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync: proper message on wrong device time #3962

Closed
AlexeyBarabash opened this issue Apr 1, 2019 · 1 comment · Fixed by brave/brave-core#2076
Closed

Sync: proper message on wrong device time #3962

AlexeyBarabash opened this issue Apr 1, 2019 · 1 comment · Fixed by brave/brave-core#2076

Comments

@AlexeyBarabash
Copy link
Contributor

AlexeyBarabash commented Apr 1, 2019

Description

When time is wrong, sync shows general error about cannot connect to server, though there is an opportunity to shows details and give a tip on how to solve.

Steps to Reproduce

  1. Adjust computer time 20 minutes forward.
  2. Create a sync chain

Actual result:

  1. See error of Couldn't connect to Sync servers

Expected result:

  1. See error of You might be having wrong system time or timezone setup on your device. Please setup the correct time and timezone Your computer's clock may be set to the wrong time or time zone. Check your clock settings.

Reproduces how often:

Easily

Brave version (brave://version info)

Brave 0.61.52 Chromium: 73.0.3683.86 (Official Build) (64-bit)
Revision f9b0bec6063ea50ce2b71f5b9abbae7beee319a6-refs/branch-heads/3683@{#858}
OS Linux

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    yes

Related issues in brave sync js lib:
brave/sync#157
brave/sync#114
brave/sync#212
also:
https://github.com/brave/browser-android-tabs/issues/788

@LaurenWags
Copy link
Member

LaurenWags commented May 17, 2019

Verified passed with

Brave 0.65.95 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Mac OS X

Verification passed on

Brave 0.65.97 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Ubuntu 18.04 LTS

Verification passed on

Brave 0.65.98 Chromium: 74.0.3729.131 (Official Build) beta (64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Windows 10 OS Build 17134.523

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment