When using vertical tabs, pinning a tab that is part of a group crashes the browser - follow up to #40201 #40365

LaurenWags · 2024-08-08T16:26:54Z

Description

Found while testing #40201 for uplift

Crash when attempting to pin a tab in a tab group still happens sometimes. When a tab group has 1-2 tabs, I couldn't reproduce the crash with 1.70.57, but it easily reproduced with 1.70.56. However, once my tab group had more tabs (3-4), then the below STR relatively reliably reproduced a crash for me. Not 100%, but the crash was fairly consistent.

Steps to reproduce

Clean profile, close and relaunch to pull griffin
Enable vertical tabs
Create a tab group with ~3 tabs
Pin one of the tabs --> sometimes crashes, sometimes does not crash
If no crash, unpin tab
Re-add to same tab group
Try to pin same tab again --> usually crashes
Note, in step 7 I've also tried pinning a different tab in the group, sometimes that caused a crash, sometimes not

Actual result

browser crashes

Expected result

browser should not crash

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave	1.70.57 Chromium: 127.0.6533.100 (Official Build) nightly (arm64) 
Revision	988908b19eb78f2e5fe4c65fa0955c5cc7e37086
OS	macOS Version 14.6.1 (Build 23G93)

Channel information

release (stable)
beta
nightly

Reproducibility

with Brave Shields disabled
with Brave Rewards disabled
in the latest version of Chrome

Miscellaneous information

Crash ID: ffc50300-15c1-690c-0000-000000000000

Call Stack

[ 00 ] base::ImmediateCrash() ( immediate_crash.h:176 )
[ 01 ] logging::NotReachedFailure() ( notreached.h:60 )
[ 02 ] content::PrerenderWebContentsDelegate::OpenURLFromTab(content::WebContents*, content::OpenURLParams const&, base::OnceCallback<void (content::NavigationHandle&)>) ( prerender_web_contents_delegate.cc:17 )
[ 03 ] TabStripLayoutHelper::SlotIsCollapsedTab(int) const ( tab_strip_layout_helper.cc:411 )
[ 04 ] TabStripLayoutHelper::CalculateIdealBounds(std::__Cr::optional<int>) ( tab_strip_layout_helper.cc:268 )
[ 05 ] TabStripLayoutHelper::UpdateIdealBounds(int) ( tab_strip_layout_helper.cc:206 )
[ 06 ] TabContainerImpl::UpdateIdealBounds() ( tab_container_impl.cc:1220 )
[ 07 ] TabContainerImpl::AnimateToIdealBounds() ( tab_container_impl.cc:621 )
[ 08 ] CompoundTabContainer::AnimateToIdealBounds() ( compound_tab_container.cc:566 )
[ 09 ] CompoundTabContainer::TransferTabBetweenContainers(int, int) ( compound_tab_container.cc:969 )
[ 10 ] BraveCompoundTabContainer::TransferTabBetweenContainers(int, int) ( brave_compound_tab_container.cc:193 )
[ 11 ] TabStrip::MoveTab(int, int, TabRendererData) ( tab_strip.cc:1156 )
[ 12 ] BrowserTabStripController::OnTabStripModelChanged(TabStripModel*, TabStripModelChange const&, TabStripSelectionChange const&) ( browser_tab_strip_controller.cc:677 )
[ 13 ] TabStripModel::OnChange(TabStripModelChange const&, TabStripSelectionChange const&) ( tab_strip_model.cc:393 )
[ 14 ] TabStripModel::OnChange(TabStripModelChange const&, TabStripSelectionChange const&) ( tab_strip_model.cc:393 )
[ 15 ] TabStripModel::SendMoveNotificationForWebContents(int, int, content::WebContents*, TabStripSelectionChange&) ( tab_strip_model.cc:2783 )
[ 16 ] TabStripModel::MoveTabToIndexImpl(int, int, std::__Cr::optional<tab_groups::TabGroupId>, bool, bool) ( tab_strip_model.cc:2638 )
[ 17 ] TabStripModel::SetTabsPinned(std::__Cr::vector<int, std::__Cr::allocator<int>>, bool) ( tab_strip_model.cc:2876 )
[ 18 ] TabStripModel::ExecuteContextMenuCommand(int, TabStripModel::ContextMenuCommand) ( tab_strip_model.cc:1476 )
[ 19 ] BraveTabStripModel::ExecuteContextMenuCommand(int, TabStripModel::ContextMenuCommand) ( brave_tab_strip_model.cc:70 )
[ 20 ] -[MenuControllerCocoa itemSelected:] ( menu_controller.mm:303 )
[ 21 ] -[MenuControllerCocoa itemSelected:] ( menu_controller.mm:303 )
[ 22 ] 0x191428ff8
[ 23 ] __43-[BrowserCrApplication sendAction:to:from:]_block_invoke ( chrome_browser_application_mac.mm:393 )
[ 24 ] base::apple::CallWithEHFrame(void () block_pointer)
[ 25 ] 0x1914f3084
[ 26 ] 0x1914f3084
[ 27 ] 0x191aa3488
[ 28 ] 0x19152b82c
[ 29 ] 0x19152b74c
[ 30 ] 0x191a99de8
[ 31 ] 0x1918c2c0c
[ 32 ] 0x1918c2980
[ 33 ] 0x191ff6c10
[ 34 ] 0x19187b844
[ 35 ] 0x191aa4c90
[ 36 ] 0x191aa9264
[ 37 ] 0x1915a96b8
[ 38 ] ui::ShowContextMenu(NSMenu*, NSEvent*, NSView*, bool, ui::ElementContext) ( menu_utils.mm:83 )
[ 39 ] views::internal::MenuRunnerImplCocoa::RunMenuAt(views::Widget*, views::MenuButtonController*, gfx::Rect const&, views::MenuAnchorPosition, int, gfx::NativeView, std::__Cr::optional<gfx::RoundedCornersF>, std::__Cr::optional<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>>) ( menu_runner_impl_cocoa.mm:91 )
[ 40 ] views::internal::MenuRunnerImplMac::RunMenuAt(views::Widget*, views::MenuButtonController*, gfx::Rect const&, views::MenuAnchorPosition, int, gfx::NativeView, std::__Cr::optional<gfx::RoundedCornersF>, std::__Cr::optional<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>>) ( menu_runner_impl_mac.mm:61 )
[ 41 ] views::MenuRunner::RunMenuAt(views::Widget*, views::MenuButtonController*, gfx::Rect const&, views::MenuAnchorPosition, ui::MenuSourceType, gfx::NativeView, std::__Cr::optional<gfx::RoundedCornersF>, std::__Cr::optional<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>>) ( menu_runner.cc:91 )
[ 42 ] TabStrip::ShowContextMenuForTab(Tab*, gfx::Point const&, ui::MenuSourceType) ( tab_strip.cc:1687 )
[ 43 ] TabStrip::TabContextMenuController::ShowContextMenuForViewImpl(views::View*, gfx::Point const&, ui::MenuSourceType) ( tab_strip.cc:2313 )
[ 44 ] views::ContextMenuController::ShowContextMenuForView(views::View*, gfx::Point const&, ui::MenuSourceType) ( context_menu_controller.cc:29 )
[ 45 ] views::View::ProcessMousePressed(ui::MouseEvent const&) ( view.cc:3555 )
[ 46 ] views::View::ProcessMousePressed(ui::MouseEvent const&) ( view.cc:3555 )
[ 47 ] views::View::OnMouseEvent(ui::MouseEvent*) ( view.cc:1652 )
[ 48 ] ui::EventDispatcher::DispatchEvent(ui::EventHandler*, ui::Event*) ( event_dispatcher.cc:187 )
[ 49 ] ui::EventDispatcherDelegate::DispatchEventToTarget(ui::EventTarget*, ui::Event*) ( event_dispatcher.cc:82 )
[ 50 ] ui::EventDispatcherDelegate::DispatchEvent(ui::EventTarget*, ui::Event*) ( event_dispatcher.cc:54 )
[ 51 ] views::internal::RootView::OnMousePressed(ui::MouseEvent const&) ( root_view.cc:498 )
[ 52 ] views::Widget::OnMouseEvent(ui::MouseEvent*) ( widget.cc:1833 )
[ 53 ] views::Widget::OnMouseEvent(ui::MouseEvent*) ( widget.cc:1833 )
[ 54 ] views::NativeWidgetMacNSWindowHost::OnMouseEvent(std::__Cr::unique_ptr<ui::Event, std::__Cr::default_delete<ui::Event>>) ( native_widget_mac_ns_window_host.mm:984 )
[ 55 ] -[BridgedContentView mouseEvent:] ( bridged_content_view.mm:656 )
[ 56 ] 0x191dbfbc4
[ 57 ] 0x1913af524
[ 58 ] 0x1913af20c
[ 59 ] -[NativeWidgetMacNSWindow sendEvent:] ( native_widget_mac_nswindow.mm:473 )
[ 60 ] 0x191a784ec
[ 61 ] __34-[BrowserCrApplication sendEvent:]_block_invoke ( chrome_browser_application_mac.mm:441 )
[ 62 ] base::apple::CallWithEHFrame(void () block_pointer)
[ 63 ] 0x1916c5d98
[ 64 ] 0x1916c5d98
[ 65 ] 0x19127601c
[ 66 ] base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) ( message_pump_apple.mm:807 )
[ 67 ] base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) ( message_pump_apple.mm:161 )
[ 68 ] base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, base::TimeDelta) ( thread_controller_with_message_pump_impl.cc:654 )
[ 69 ] non-virtual thunk to base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, base::TimeDelta) ( run_loop.cc:0 )
[ 70 ] base::RunLoop::Run(base::Location const&) ( run_loop.cc:134 )
[ 71 ] content::BrowserMainLoop::RunMainMessageLoop() ( browser_main_loop.cc:1085 )
[ 72 ] content::BrowserMainRunnerImpl::Run() ( browser_main_runner_impl.cc:160 )
[ 73 ] content::BrowserMain(content::MainFunctionParams) ( browser_main.cc:34 )
[ 74 ] content::RunContentProcess(content::ContentMainParams, content::ContentMainRunner*) ( content_main.cc:332 )
[ 75 ] content::ContentMain(content::ContentMainParams) ( content_main.cc:345 )
[ 76 ] content::RunContentProcess(content::ContentMainParams, content::ContentMainRunner*) ( content_main.cc:332 )
[ 77 ] content::ContentMain(content::ContentMainParams) ( content_main.cc:345 )
[ 78 ] ChromeMain ( chrome_main.cc:192 )
[ 79 ] 0x18d5bb150
[ 80 ] 0x18d5bb150

Crash ID: b1c70300-15c1-690c-0000-000000000000

Call Stack

[ 00 ] base::ImmediateCrash() ( immediate_crash.h:176 )
[ 01 ] logging::NotReachedFailure() ( notreached.h:60 )
[ 02 ] content::PrerenderWebContentsDelegate::OpenURLFromTab(content::WebContents*, content::OpenURLParams const&, base::OnceCallback<void (content::NavigationHandle&)>) ( prerender_web_contents_delegate.cc:17 )
[ 03 ] TabStripLayoutHelper::SlotIsCollapsedTab(int) const ( tab_strip_layout_helper.cc:411 )
[ 04 ] TabStripLayoutHelper::CalculateIdealBounds(std::__Cr::optional<int>) ( tab_strip_layout_helper.cc:268 )
[ 05 ] TabStripLayoutHelper::UpdateIdealBounds(int) ( tab_strip_layout_helper.cc:206 )
[ 06 ] TabContainerImpl::UpdateIdealBounds() ( tab_container_impl.cc:1220 )
[ 07 ] TabContainerImpl::AnimateToIdealBounds() ( tab_container_impl.cc:621 )
[ 08 ] CompoundTabContainer::AnimateToIdealBounds() ( compound_tab_container.cc:566 )
[ 09 ] CompoundTabContainer::TransferTabBetweenContainers(int, int) ( compound_tab_container.cc:969 )
[ 10 ] BraveCompoundTabContainer::TransferTabBetweenContainers(int, int) ( brave_compound_tab_container.cc:193 )
[ 11 ] TabStrip::MoveTab(int, int, TabRendererData) ( tab_strip.cc:1156 )
[ 12 ] BrowserTabStripController::OnTabStripModelChanged(TabStripModel*, TabStripModelChange const&, TabStripSelectionChange const&) ( browser_tab_strip_controller.cc:677 )
[ 13 ] TabStripModel::OnChange(TabStripModelChange const&, TabStripSelectionChange const&) ( tab_strip_model.cc:393 )
[ 14 ] TabStripModel::OnChange(TabStripModelChange const&, TabStripSelectionChange const&) ( tab_strip_model.cc:393 )
[ 15 ] TabStripModel::SendMoveNotificationForWebContents(int, int, content::WebContents*, TabStripSelectionChange&) ( tab_strip_model.cc:2783 )
[ 16 ] TabStripModel::MoveTabToIndexImpl(int, int, std::__Cr::optional<tab_groups::TabGroupId>, bool, bool) ( tab_strip_model.cc:2638 )
[ 17 ] TabStripModel::SetTabsPinned(std::__Cr::vector<int, std::__Cr::allocator<int>>, bool) ( tab_strip_model.cc:2876 )
[ 18 ] TabStripModel::ExecuteContextMenuCommand(int, TabStripModel::ContextMenuCommand) ( tab_strip_model.cc:1476 )
[ 19 ] BraveTabStripModel::ExecuteContextMenuCommand(int, TabStripModel::ContextMenuCommand) ( brave_tab_strip_model.cc:70 )
[ 20 ] -[MenuControllerCocoa itemSelected:] ( menu_controller.mm:303 )
[ 21 ] -[MenuControllerCocoa itemSelected:] ( menu_controller.mm:303 )
[ 22 ] 0x191428ff8
[ 23 ] __43-[BrowserCrApplication sendAction:to:from:]_block_invoke ( chrome_browser_application_mac.mm:393 )
[ 24 ] base::apple::CallWithEHFrame(void () block_pointer)
[ 25 ] 0x1914f3084
[ 26 ] 0x1914f3084
[ 27 ] 0x191aa3488
[ 28 ] 0x19152b82c
[ 29 ] 0x19152b74c
[ 30 ] 0x191a99de8
[ 31 ] 0x1918c2c0c
[ 32 ] 0x1918c2980
[ 33 ] 0x191ff6c10
[ 34 ] 0x19187b844
[ 35 ] 0x191aa4c90
[ 36 ] 0x191aa9264
[ 37 ] 0x1915a96b8
[ 38 ] ui::ShowContextMenu(NSMenu*, NSEvent*, NSView*, bool, ui::ElementContext) ( menu_utils.mm:83 )
[ 39 ] views::internal::MenuRunnerImplCocoa::RunMenuAt(views::Widget*, views::MenuButtonController*, gfx::Rect const&, views::MenuAnchorPosition, int, gfx::NativeView, std::__Cr::optional<gfx::RoundedCornersF>, std::__Cr::optional<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>>) ( menu_runner_impl_cocoa.mm:91 )
[ 40 ] views::internal::MenuRunnerImplMac::RunMenuAt(views::Widget*, views::MenuButtonController*, gfx::Rect const&, views::MenuAnchorPosition, int, gfx::NativeView, std::__Cr::optional<gfx::RoundedCornersF>, std::__Cr::optional<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>>) ( menu_runner_impl_mac.mm:61 )
[ 41 ] views::MenuRunner::RunMenuAt(views::Widget*, views::MenuButtonController*, gfx::Rect const&, views::MenuAnchorPosition, ui::MenuSourceType, gfx::NativeView, std::__Cr::optional<gfx::RoundedCornersF>, std::__Cr::optional<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>>) ( menu_runner.cc:91 )
[ 42 ] TabStrip::ShowContextMenuForTab(Tab*, gfx::Point const&, ui::MenuSourceType) ( tab_strip.cc:1687 )
[ 43 ] TabStrip::TabContextMenuController::ShowContextMenuForViewImpl(views::View*, gfx::Point const&, ui::MenuSourceType) ( tab_strip.cc:2313 )
[ 44 ] views::ContextMenuController::ShowContextMenuForView(views::View*, gfx::Point const&, ui::MenuSourceType) ( context_menu_controller.cc:29 )
[ 45 ] views::View::ProcessMousePressed(ui::MouseEvent const&) ( view.cc:3555 )
[ 46 ] views::View::ProcessMousePressed(ui::MouseEvent const&) ( view.cc:3555 )
[ 47 ] views::View::OnMouseEvent(ui::MouseEvent*) ( view.cc:1652 )
[ 48 ] ui::EventDispatcher::DispatchEvent(ui::EventHandler*, ui::Event*) ( event_dispatcher.cc:187 )
[ 49 ] ui::EventDispatcherDelegate::DispatchEventToTarget(ui::EventTarget*, ui::Event*) ( event_dispatcher.cc:82 )
[ 50 ] ui::EventDispatcherDelegate::DispatchEvent(ui::EventTarget*, ui::Event*) ( event_dispatcher.cc:54 )
[ 51 ] views::internal::RootView::OnMousePressed(ui::MouseEvent const&) ( root_view.cc:498 )
[ 52 ] views::Widget::OnMouseEvent(ui::MouseEvent*) ( widget.cc:1833 )
[ 53 ] views::Widget::OnMouseEvent(ui::MouseEvent*) ( widget.cc:1833 )
[ 54 ] views::NativeWidgetMacNSWindowHost::OnMouseEvent(std::__Cr::unique_ptr<ui::Event, std::__Cr::default_delete<ui::Event>>) ( native_widget_mac_ns_window_host.mm:984 )
[ 55 ] -[BridgedContentView mouseEvent:] ( bridged_content_view.mm:656 )
[ 56 ] 0x191dbfbc4
[ 57 ] 0x1913af524
[ 58 ] 0x1913af20c
[ 59 ] -[NativeWidgetMacNSWindow sendEvent:] ( native_widget_mac_nswindow.mm:473 )
[ 60 ] 0x191a784ec
[ 61 ] __34-[BrowserCrApplication sendEvent:]_block_invoke ( chrome_browser_application_mac.mm:441 )
[ 62 ] base::apple::CallWithEHFrame(void () block_pointer)
[ 63 ] 0x1916c5d98
[ 64 ] 0x1916c5d98
[ 65 ] 0x19127601c
[ 66 ] base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) ( message_pump_apple.mm:807 )
[ 67 ] base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) ( message_pump_apple.mm:161 )
[ 68 ] base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, base::TimeDelta) ( thread_controller_with_message_pump_impl.cc:654 )
[ 69 ] non-virtual thunk to base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, base::TimeDelta) ( run_loop.cc:0 )
[ 70 ] base::RunLoop::Run(base::Location const&) ( run_loop.cc:134 )
[ 71 ] content::BrowserMainLoop::RunMainMessageLoop() ( browser_main_loop.cc:1085 )
[ 72 ] content::BrowserMainRunnerImpl::Run() ( browser_main_runner_impl.cc:160 )
[ 73 ] content::BrowserMain(content::MainFunctionParams) ( browser_main.cc:34 )
[ 74 ] content::RunContentProcess(content::ContentMainParams, content::ContentMainRunner*) ( content_main.cc:332 )
[ 75 ] content::ContentMain(content::ContentMainParams) ( content_main.cc:345 )
[ 76 ] content::RunContentProcess(content::ContentMainParams, content::ContentMainRunner*) ( content_main.cc:332 )
[ 77 ] content::ContentMain(content::ContentMainParams) ( content_main.cc:345 )
[ 78 ] ChromeMain ( chrome_main.cc:192 )
[ 79 ] 0x18d5bb150
[ 80 ] 0x18d5bb150

The text was updated successfully, but these errors were encountered:

bsclifton · 2024-08-08T20:33:47Z

cc: @sangwoo108

iefremov · 2024-09-16T21:02:43Z

@bsclifton we need someone to pick this one up

simonhong · 2024-09-19T06:23:04Z

@bsclifton we need someone to pick this one up

Checking the PR brave/brave-core#25406

simonhong · 2024-09-19T08:55:02Z

Found more concrete STR.
To make crash, create group with 3 tabs.
and try to pin second tab in the group. Always crashed.

simonhong · 2024-10-04T00:26:03Z

This is upstream issue. Filed https://issues.chromium.org/issues/371112521.
This crash comes from using CompoundTabContainer what we use for vertical tab.
However, in the upstream, that class is only used under the SplitTabStrip that disabled by default.
So, maybe it's not the urgent issue for upstream. but we're using it in release.
I think we should upstream fix.

simonhong · 2024-10-14T06:40:14Z

Trying to fix with https://chromium-review.googlesource.com/c/chromium/src/+/5919961

LaurenWags · 2024-10-15T19:19:45Z

Requires 1.71.113 or higher for verification 👍🏻 @brave/qa-team can see concrete STR via brave/brave-core#25983 (comment) and my verification notes from brave/brave-core#25983 (comment) for guidance when testing.

GeetaSarvadnya · 2024-10-16T15:28:33Z

Verification INPROGRESS on

Brave | 1.71.113 Chromium: 130.0.6723.58 (Official Build) (64-bit)
-- | --
Revision | 3ee74228044546a84c661332ddb441a7a68108fa
OS | Windows 10 Version 22H2 (Build 19045.5011)

Reproduced the issue on 1.70.126

Verified the test plan from brave/brave-core#25983 and ensured that there is no crash after pinning the 2nd tab in a tab group

LaurenWags added bug crash feature/pinned-tabs QA/Yes OS/Desktop feature/vertical-tabs labels Aug 8, 2024

LaurenWags mentioned this issue Aug 8, 2024

Fix crash when pinning tabs that are grouped in vertical tab strip brave/brave-core#25016

Merged

24 tasks

bsclifton added the priority/P2 A bad problem. We might uplift this to the next planned release. label Aug 8, 2024

bsclifton mentioned this issue Aug 22, 2024

Crash Report #40152

Closed

Ilie-Lesan mentioned this issue Sep 2, 2024

When using vertical tabs pinning a tab that is part of a group crashes the browser brave/brave-core#25406

Closed

24 tasks

simonhong self-assigned this Oct 4, 2024

simonhong mentioned this issue Oct 15, 2024

Clear group id in-advance when tab is moved to pinned container brave/brave-core#25983

Merged

24 tasks

simonhong closed this as completed in brave/brave-core#25983 Oct 15, 2024

brave-builds added this to the 1.73.x - Nightly milestone Oct 15, 2024

This was referenced Oct 15, 2024

Clear group id in-advance when tab is moved to pinned container (uplift to 1.72.x) brave/brave-core#25986

Merged

Clear group id in-advance when tab is moved to pinned container (uplift to 1.71.x) brave/brave-core#25987

Merged

simonhong added the release-notes/include label Oct 15, 2024

brave-builds modified the milestones: 1.73.x - Nightly, 1.72.x - Beta, 1.71.x - Release Oct 15, 2024

LaurenWags mentioned this issue Oct 16, 2024

Desktop Release Notes for 1.71.x Release #41669

Closed

GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 16, 2024

GeetaSarvadnya added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

When using vertical tabs, pinning a tab that is part of a group crashes the browser - follow up to #40201 #40365

When using vertical tabs, pinning a tab that is part of a group crashes the browser - follow up to #40201 #40365

LaurenWags commented Aug 8, 2024

bsclifton commented Aug 8, 2024

iefremov commented Sep 16, 2024

simonhong commented Sep 19, 2024

simonhong commented Sep 19, 2024

simonhong commented Oct 4, 2024

simonhong commented Oct 14, 2024

LaurenWags commented Oct 15, 2024

GeetaSarvadnya commented Oct 16, 2024 •

edited

Loading

When using vertical tabs, pinning a tab that is part of a group crashes the browser - follow up to #40201 #40365

When using vertical tabs, pinning a tab that is part of a group crashes the browser - follow up to #40201 #40365

Comments

LaurenWags commented Aug 8, 2024

Description

Steps to reproduce

Actual result

Expected result

Reproduces how often

Brave version (brave://version info)

Channel information

Reproducibility

Miscellaneous information

bsclifton commented Aug 8, 2024

iefremov commented Sep 16, 2024

simonhong commented Sep 19, 2024

simonhong commented Sep 19, 2024

simonhong commented Oct 4, 2024

simonhong commented Oct 14, 2024

LaurenWags commented Oct 15, 2024

GeetaSarvadnya commented Oct 16, 2024 • edited Loading

GeetaSarvadnya commented Oct 16, 2024 •

edited

Loading