-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[development] npm run sync
fails with Brave Browser Sync ERROR
#40509
Comments
Full output
|
@hamirmahal are you still having this issue? You do need to have a directory structure like:
Based on the error messages seen above, it seems your working directory is |
I actually removed the I may remove the entire Full output
|
I'm trying to rerun Full output
|
@hamirmahal OK that last run you did looks good - it finished syncing, so you can now just run Is
|
Ah, okay. I thought things went wrong because there was a lot of red text at the end, followed by a message saying that not everything was successful, also in red text. It might be worth modifying that to have some sort of green 'all clear' message to improve the developer experience.
Here's the output.
|
Yeah the red text is not good - but you made it past the sync part, at least it looked that way from the logs. Meaning, your local code should have the latest Chromium and it's supposed to have done a reset. Something looks off though - those files should absolutely be there. Just for a sanity check, do you have these files on disk?
If not, then the Chromium cloning step might have failed. |
Hmm... It looks like I have the first and last one, but not the middle one.
|
Sorry for not responding here - something is definitely wrong w/ git if the clone said it finished but there are missing files. I'm not sure what to recommend next. Maybe uninstall/reinstall git or check your git config? I'm going to close this issue as there isn't a problem with the product. But if you would like to continue to troubleshoot, you can keep posting here. Thanks |
Description
npm run sync
fails withSteps to reproduce
npm run sync
Actual result
npm run sync
fails.Expected result
npm run sync
should work.Reproduces how often
Easily reproduced
Brave version (brave://version info)
n/a
Channel information
Reproducibility
Miscellaneous information
No response
The text was updated successfully, but these errors were encountered: