Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Nala]: Fix sidebar colors #40749

Closed
fallaciousreasoning opened this issue Aug 29, 2024 · 2 comments · Fixed by brave/brave-core#25372
Closed

[Nala]: Fix sidebar colors #40749

fallaciousreasoning opened this issue Aug 29, 2024 · 2 comments · Fixed by brave/brave-core#25372
Assignees
@fallaciousreasoning
Labels
OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/exclude web-ui
Milestone
1.71.x - Release

Comments

@fallaciousreasoning
Copy link

The sidebar colors are off in Private/Tor windows when the browser is in light mode because the theme for the Sidebar doesn't match the theme passed into the color mixer.

This results in a weird header color for the sidebar

Note: We should have a think about:

  1. Whether is actually makes sense to show these pages in Private mode
  2. Whether we want these pages to follow the non-Private theme color
@fallaciousreasoning fallaciousreasoning added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/exclude web-ui OS/Desktop labels Aug 29, 2024
@fallaciousreasoning fallaciousreasoning self-assigned this Aug 29, 2024
@fallaciousreasoning
Copy link
Author

This issue was found by @simonhong in brave/brave-core#25337 (comment)

@brave brave deleted a comment Aug 29, 2024
This was referenced Aug 29, 2024
Merged
Merged
@brave-builds brave-builds added this to the 1.71.x - Nightly milestone Aug 29, 2024
@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.71.110 Chromium: 129.0.6668.100 (Official Build) beta (64-bit)
-- | --
Revision | 46cd0b1af7127687895fcaceff93dd80e29e6f2b
OS | Windows 11 Version 23H2 (Build 22631.4317)

Verified from the testplan brave/brave-core#25372 (comment) in both light and dark modes.

Confirmed the headers of Bookmarks & Reading list do not have yellow color background for both Private & Tor Windows

Bookmarks

Private/Tor - Light Private/Tor - Dark
Image Image
Image Image

Reading list

Private/Tor - Light Private/Tor - Dark
Image Image
Image Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fallaciousreasoning fallaciousreasoning

Labels
OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/exclude web-ui
Projects
None yet
Milestone
1.71.x - Release
Development

Successfully merging a pull request may close this issue.

[Nala]: Fix sidebar header brave/brave-core
3 participants
@fallaciousreasoning @brave-builds @MadhaviSeelam