Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address is Hidden in Deposit Funds Panel View #40826

Closed
3 of 6 tasks
Douglashdaniel opened this issue Sep 3, 2024 · 1 comment · Fixed by brave/brave-core#25413
Closed
3 of 6 tasks

Address is Hidden in Deposit Funds Panel View #40826

Douglashdaniel opened this issue Sep 3, 2024 · 1 comment · Fixed by brave/brave-core#25413
Assignees
@Douglashdaniel
Labels
enhancement feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.71.x - Release

Comments

@Douglashdaniel
Copy link

Description

It is currently not obvious that you need to scroll down to see your address in the Deposit Funds view in the Wallet Panel.

Steps to reproduce

  1. Open the Wallet Panel and navigate to the Deposit Funds screen.
  2. Select a Token to deposit and click continue.
  3. You have to scroll down to be able to know that the Address is bellow the QR code.

Actual result

Screenshot 49

Expected result

We should move the Address above the QR code to make it more obvious.
Screenshot 50

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.69.153 Chromium: 128.0.6613.85 (Official Build) (arm64)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response
@Douglashdaniel Douglashdaniel added enhancement QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Sep 3, 2024
@Douglashdaniel Douglashdaniel self-assigned this Sep 3, 2024
@Douglashdaniel Douglashdaniel mentioned this issue Sep 3, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.71.x - Nightly milestone Sep 4, 2024
@srirambv
Copy link
Contributor

srirambv commented Oct 1, 2024

Verification passed on

Brave 1.71.97 Chromium: 129.0.6668.70 (Official Build) beta (64-bit)
Revision de99cbcb1aa0aa00877d356e4733f4e5481e89eb
OS Windows 11 Version 23H2 (Build 22631.4169)
  • Verified steps from brave/brave-core#25413
  • Verified deposit address is shown above the QR code in panel
  • Verified for all deposit account types
  • Encountered #41315
Solana Ethereum Filecoin BTC ZCash
image image image image image

@LaurenWags LaurenWags mentioned this issue Oct 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
enhancement feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.71.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Move Address above QR code on Deposit screen brave/brave-core
3 participants
@srirambv @Douglashdaniel @brave-builds