Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation bubble is not shown on nightly builds #4089

Closed
yrliou opened this issue Apr 12, 2019 · 1 comment · Fixed by brave/brave-core#2212
Closed

Translation bubble is not shown on nightly builds #4089

yrliou opened this issue Apr 12, 2019 · 1 comment · Fixed by brave/brave-core#2212

Comments

@yrliou
Copy link
Member

yrliou commented Apr 12, 2019

Description

When visits a page in a different locale on nightly, translation bubble is not shown automatically.
This is because we don't have google API key configured, so the translate flow is not triggered.

Steps to Reproduce

  1. Visit https://www.deutschland.de/de/topic/wissen/school-of-games-ausbildung-zum-spieleentwickler or any pages not in your default locale.

Actual result:

No translation bubble prompt in the url bar.

Expected result:

Should have a translation bubble prompt in the url bar.

Reproduces how often:

Every time.

Brave version (brave://version info)

Version 0.65.50 Chromium: 74.0.3729.61 (Official Build) nightly (64-bit)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? No.
@LaurenWags
Copy link
Member

LaurenWags commented May 17, 2019

Verified passed with

Brave 0.65.95 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Mac OS X
  • Verified STR from description
    Screen Shot 2019-05-17 at 4 11 58 PM

Verification passed on

Brave 0.65.95 Chromium: 74.0.3729.131 (Official Build) beta (64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Windows 10 OS Build 17134.523
  • Verified the STR mentioned in the description
    image

Verification passed on

Brave 0.65.97 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Ubuntu 18.04 LTS

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment