Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brave/browser/ai_chat, brave/browser/skus, brave/browser/misc_metrics should have it's own target #41177

Closed
yrliou opened this issue Sep 20, 2024 · 0 comments · Fixed by brave/brave-core#25681
Closed

brave/browser/ai_chat, brave/browser/skus, brave/browser/misc_metrics should have it's own target #41177

yrliou opened this issue Sep 20, 2024 · 0 comments · Fixed by brave/brave-core#25681
Assignees
@yrliou
Labels
dev-concern OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude
Milestone
1.73.x - Release

Comments

@yrliou
Copy link
Member

yrliou commented Sep 20, 2024 •
edited
Loading

They shouldn't be directly in chrome/browser target.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yrliou yrliou

Labels
dev-concern OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
1.73.x - Release
Development

Successfully merging a pull request may close this issue.

Own target for brave/browser/ai_chat, brave/browser/skus, brave/brows… brave/brave-core
2 participants
@yrliou @brave-builds