Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename brave_components_sync_driver_* gn vars #41280

Open
AlexeyBarabash opened this issue Sep 27, 2024 · 1 comment · May be fixed by brave/brave-core#25484
Open

Rename brave_components_sync_driver_* gn vars #41280

AlexeyBarabash opened this issue Sep 27, 2024 · 1 comment · May be fixed by brave/brave-core#25484
Labels
dev-concern

Comments

@AlexeyBarabash
Copy link
Contributor

Description

We need to rename
brave_components_sync_driver_sources/brave_components_sync_driver_deps

variables to

brave_components_sync_service_deps/brave_components_sync_service_deps

to match directory names.

This comes from
https://source.chromium.org/chromium/chromium/src/+/91c345cf4eac0adbb428db6449384028dfac7bd3

[sync] Rename components/sync/driver to components/sync/service

It was agreed within the Sync team that the name 'driver' conveys
little and is a historic artifact. The new name, 'service', reflects
what most dependent targets care about: SyncService and adjacent APIs.
@AlexeyBarabash AlexeyBarabash linked a pull request Sep 27, 2024 that will close this issue
Open
24 tasks
@AlexeyBarabash
Copy link
Contributor Author

It looks it will be fixed at
brave/brave-core#25484

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev-concern
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Sync] Add an option in setting page to Enter Custom Sync Url jagadeshjai/brave-core
1 participant
@AlexeyBarabash