Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional logging to help diagnose issues when downloading catalogs #4160

Closed
tmancey opened this issue Apr 18, 2019 · 1 comment · Fixed by brave/brave-core#2267
Closed
Assignees

Comments

@tmancey
Copy link
Contributor

tmancey commented Apr 18, 2019

Add additional logging to help diagnose issues when downloading catalogs and fetch the latest catalog every 15 minutes instead of every 2 hours if the --brave-ads-debug command-line arg is passed

@LaurenWags
Copy link
Member

LaurenWags commented May 20, 2019

Verified passed with

Brave 0.65.97 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Mac OS X
  1. Launched clean profile with --enable-logging=stderr --log-level=2 --vmodule=brave_ads=3 --brave-ads-debug.
  2. Enabled Rewards.
  3. Saw Start collecting activity in 962 seconds in terminal (roughly 16 minutes).
  4. Verified 962 seconds later a new catalog was pulled (verified terminal messaging).
  5. Verified another Start collecting activity message was displayed in the terminal again - this time for 953 seconds which is just under 16 minutes.

Verification passed on

Brave 0.65.97 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Ubuntu 18.04 LTS

Used STR provided by @LaurenWags

Verification passed on

Brave 0.65.107 Chromium: 75.0.3770.38 (Official Build) beta (64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • Verified the above STR provided by @LaurenWags
  • Verified the logs in chrome_debug.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants