Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating from older build doesn't show notification to try Ads #4404

Closed
LaurenWags opened this issue May 10, 2019 · 4 comments
Closed

Updating from older build doesn't show notification to try Ads #4404

LaurenWags opened this issue May 10, 2019 · 4 comments

Comments

@LaurenWags
Copy link
Member

Description

Found while testing #4224

After following the STR in above issue and updating to 0.64.74, the Ads panel no longer showed the incorrect error message but I did not receive a notification to try Ads.

Steps to Reproduce

Scenario 1:

  1. Install an older build say (0.58.21)
  2. Enable Rewards. ensure ads is not available
  3. Upgrade to 0.63.48 or 0.63.55
  4. Ads shows sorry not available for your region even if the criteria matches
  5. Update to 0.64.74
  6. Ads panel shows toggle (you can enable Ads) but there is no notification alerting you to try ads.

Scenario 2:

  1. Install an older build say (0.58.21)
  2. Enable Rewards. ensure ads is not available
  3. Update to 0.64.74 directly (skipping 0.63.x versions)
  4. Ads panel shows toggle (you can enable Ads) but there is no notification alerting you to try ads.

Actual result:

No notification to alert the user that Ads are now available.

Expected result:

Notification to try Ads is shown on BAT logo.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.64.74 Chromium: 74.0.3729.131 (Official Build) (64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Mac OS X

Version/Channel Information:

  • Can you reproduce this issue with the current release? reproduced with RC build
  • Can you reproduce this issue with the beta channel? unsure
  • Can you reproduce this issue with the dev channel? unsure
  • Can you reproduce this issue with the nightly channel? unsure

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

cc @brave/legacy_qa @rebron

@LaurenWags
Copy link
Member Author

Also tested scenario 2 with the following versions:
0.59.35 --> 0.64.74, scenario 2 reproduces
0.60.45 --> 0.64.74, scenario 2 does not reproduce
0.61.51 --> 0.64.74, scenario 2 does not reproduce
0.62.51 --> 0.64.74, scenario 2 does not reproduce
0.63.48 --> 0.64.74, scenario 2 does not reproduce
0.63.55 --> 0.64.74, scenario 2 does not reproduce

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 14, 2019

Scenario 1 is Reproducible on Windows 10 x64:
0.58.12-->upgraded to 0.63.48-->upgraded to 0.64.74 ( Ads not supported message even though criteria matches, no notification to turn on Ads)

Scenario 2 is Also Reproducible with below version:

0.57.17-->upgraded to 0.64.74 (No notification message to enable Ads)

Brave 0.64.74 Chromium: 74.0.3729.131 (Official Build) (64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Windows 10 OS Build 17134.523

Scenario 2 is NOT Reproducible on below versions:
0.61.50 --> 0.64.74 -- NOT Reproducible

@jsecretan jsecretan added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jun 12, 2019
@tmancey
Copy link
Contributor

tmancey commented Jul 10, 2019

@LaurenWags This ticket will be superseded and subsequently fixed by #4383, are you happy for us to close this ticket please?

@LaurenWags
Copy link
Member Author

Closing per @tmancey comment above - issue is to be superseded/fixed by #4383

@kjozwiak kjozwiak added closed/duplicate Issue has already been reported and removed QA/Test-Plan-Specified QA/Yes priority/P3 The next thing for us to work on. It'll ride the trains. labels Jul 11, 2019
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Mar 6, 2020
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants