Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hackerone] block all external protocol handler requests in Tor tabs #4461

Closed
diracdeltas opened this issue May 15, 2019 · 0 comments · Fixed by brave/brave-core#2993
Closed
Assignees
Labels
feature/tor/leakproofing Eliminating unexpected ways that someone using Tor might be unmasked. feature/tor priority/P3 The next thing for us to work on. It'll ride the trains. QA/Test-Plan-Specified QA/Yes

Comments

@diracdeltas
Copy link
Member

via https://hackerone.com/bugs?subject=brave&report_id=577956

Although opening external protocols triggers a confirmation box, users can be tricked into opening them anyway. Also users who click 'yes' may not be aware that external protocols may leak their real IP.

For defense in depth, it is best to disable external protocols entirely in Tor mode. In b-l we had a whitelisted list of protocols for tor mode: https://github.com/brave/browser-laptop/blob/0155c9ee2fb724fbd5e43c84b8f7e02d0e5b4cf1/app/filtering.js#L107. This should be straightforward to port. Note that the check for whitelisted request protocols must happen before the external protocol handler code runs.

@diracdeltas diracdeltas added sec-low priority/P3 The next thing for us to work on. It'll ride the trains. feature/tor/leakproofing Eliminating unexpected ways that someone using Tor might be unmasked. labels May 15, 2019
@diracdeltas diracdeltas changed the title [hackerone] only allow whitelisted protocol handlers in Tor tabs [hackerone] block all external protocol handler requests in Tor tabs Jul 23, 2019
@darkdh darkdh self-assigned this Jul 23, 2019
@bbondy bbondy added this to the 0.69.x - Release milestone Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/tor/leakproofing Eliminating unexpected ways that someone using Tor might be unmasked. feature/tor priority/P3 The next thing for us to work on. It'll ride the trains. QA/Test-Plan-Specified QA/Yes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants