Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The letter s should be in caps in Get started as per the design spec - Follow up of #960 #4499

Closed
GeetaSarvadnya opened this issue May 20, 2019 · 2 comments
Labels
bug feature/user-interface All UI related needs-text-change This change requires some careful wording. QA/Yes

Comments

@GeetaSarvadnya
Copy link

Description

The letter s should be in caps in Get started - Follow up of #960

Steps to Reproduce

Actual result:

image

Expected result:

As per the design spec mentioned in #960 (comment) the text should be Get Started instead of Get started

If it's expected please close the issue

Reproduces how often:

Always

Brave version (brave://version info)

Brave 0.65.95 Chromium: 74.0.3729.131 (Official Build) beta (64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Windows 10 OS Build 17134.523

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel?Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

@petemill @rebron

@GeetaSarvadnya GeetaSarvadnya changed the title The letter s should be in caps in label Get started as per the design spec - Follow up of #960 The letter s should be in caps in Get started as per the design spec - Follow up of #960 May 20, 2019
@bsclifton bsclifton added the needs-text-change This change requires some careful wording. label May 20, 2019
@btlechowski
Copy link

Reproduced on

Brave 0.65.97 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Ubuntu 18.04 LTS

image

@petemill
Copy link
Member

Thanks for reporting but the decision is to use sentence casing.

@bbondy bbondy added this to the Closed / Invalid milestone Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/user-interface All UI related needs-text-change This change requires some careful wording. QA/Yes
Projects
None yet
Development

No branches or pull requests

5 participants