Create .pkg files for all channels

[aekeus]

In the build system, please create .pkg files for all channels, not just release. This will be useful for allowing tracking by referral codes across all channels. The .pkg files should also be transferred to the /latest bucket on S3.

[aekeus]

cc @emerick @mihaiplesa

[LaurenWags]

Verified .pkg files exist for Nightly, Dev, Beta. Downloaded latest .pkg and verified that expected version was installed. However, for Nightly, Dev, Beta each time the .pkg was installed, an extra Brave folder was created under BraveSoftware (~/Library/Application Support/BraveSoftware) which contained a promoCode file. This was unexpected - should this be occurring? This does not happen for Release Channel.

Brave	0.69.49 Chromium: 75.0.3770.100 (Official Build)nightly (64-bit)
Revision	cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS	Mac OS X

• Downloaded .pkg file for this Nightly version. Installed. Saw extra Brave folder under `~/Library/Application Support/BraveSoftware:
  

Reproduced with Dev .pkg file

Brave	0.68.98 Chromium: 75.0.3770.100 (Official Build) dev(64-bit)
Revision	cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS	Mac OS X

Reproduced with Beta .pkg file

Brave	0.67.106 Chromium: 75.0.3770.100 (Official Build) beta(64-bit)
Revision	cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS	Mac OS X

Did not reproduce with Release Channel .pkg file

Brave	0.66.99 Chromium: 75.0.3770.100 (Official Build) (64-bit)
Revision	cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS	Mac OS X

cc @kjozwiak to try on macOS also

[kjozwiak]

Seeing the same thing as @LaurenWags, example:

• ~/Library/Application\ Support/BraveSoftware/Brave/promoCode --> Browser-Nighyly (0.69.52 Chromium: 75.0.3770.100)
• ~/Library/Application\ Support/BraveSoftware/Brave/promoCode --> Browser-Dev (0.68.99 CR: 75.0.3770.100)
• ~/Library/Application\ Support/BraveSoftware/Brave/promoCode --> Browser-Beta (0.67.107 CR: 75.0.3770.100)

@aekeus seems like an issue. I don't think we should be creating a promoCode under ~/Library/Application\ Support/BraveSoftware/Brave/ when installing nightly, dev or beta.

[emerick]

I think this might be fallout from #4600. In particular, it looks like the presence of a dash in the non-release package names (e.g., Browser-Beta) is causing the filename to be interpreted as a promo code.

[kjozwiak]

@emerick @aekeus I'm assuming this is something we want fixed before 0.67.x moves to release?

[emerick]

@kjozwiak Yes, I think that makes sense. Should be an easy fix, we just need to guard against Browser-Beta etc. being accepted as a valid promo code.

[LaurenWags]

Logged #5264 as follow up issue, thanks @emerick 😄