Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweet on tip from panel uses name instead of Twitter handle #4597

Closed
mandar-brave opened this issue May 24, 2019 · 2 comments · Fixed by brave/brave-core#2502
Closed

Tweet on tip from panel uses name instead of Twitter handle #4597

mandar-brave opened this issue May 24, 2019 · 2 comments · Fixed by brave/brave-core#2502

Comments

@mandar-brave
Copy link

Currently when the user tweets out, we are using the profile-name instead of using the twitter handle. See error image:
image

should be @brave (handle) instead of Brave Software (text)

cc @emerick @davidtemkin

@mandar-brave mandar-brave added feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. labels May 24, 2019
@mandar-brave
Copy link
Author

STR: this issue happens only via the panel!
So go to any verified twitter account on the panel, tip via BAT panel.
Go through the process and then tweet; the tweet should use a handle @ vs. using the profile name.

@NejcZdovc

@emerick emerick self-assigned this May 24, 2019
@emerick emerick changed the title Tweet needs to be fixed Tweet on tip from panel uses real name instead of Twitter handle May 24, 2019
@emerick emerick changed the title Tweet on tip from panel uses real name instead of Twitter handle Tweet on tip from panel uses name instead of Twitter handle May 24, 2019
@emerick emerick added the QA/Yes label May 24, 2019
@NejcZdovc NejcZdovc added this to the 0.67.x - Nightly milestone May 27, 2019
@LaurenWags
Copy link
Member

LaurenWags commented Jul 11, 2019

Verified passed with

Brave 0.67.107 Chromium: 75.0.3770.100 (Official Build) beta(64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Mac OS X

Tipping Twitter user from in-line tip button and selecting tweet button from Thank You banner, this is the tweet that's generated:
Screen Shot 2019-07-11 at 11 32 01 AM

Tipping YT video from panel (unable to tip YT channel correctly due to #5217) and selecting tweet button from Thank You banner, this is the tweet that's generated:
Screen Shot 2019-07-11 at 1 06 44 PM

Tipping Twitch channel from panel and selecting tweet button from Thank You banner, this is the tweet that's generated:
Screen Shot 2019-07-11 at 1 07 12 PM

Tipping Twitch video from panel and selecting tweet button from Thank You banner, this is the tweet that's generated:
Screen Shot 2019-07-11 at 1 07 33 PM

Tipping regular site from panel and selecting tweet button from Thank You banner, this is the tweet that's generated:
Screen Shot 2019-07-11 at 1 08 02 PM

Verification passed on

Brave 0.67.108 Chromium: 75.0.3770.100 (Official Build) beta (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Windows 10 OS Version 1803 (Build 17134.523)

Verification passed on

Brave 0.67.110 Chromium: 75.0.3770.100 (Official Build) beta(64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Ubuntu 18.04 LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants